Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 453133003: Remove Matrix/Clip State collapse code (Closed)

Created:
6 years, 4 months ago by robertphillips
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove Matrix/Clip State collapse code Given recent & upcoming changes (e.g., removal of save flags & SkRecord picture backend) this will have to be reimplemented. Committed: https://skia.googlesource.com/skia/+/6b143b080820c34c9c0f80e5c682939e9ee3879d

Patch Set 1 #

Patch Set 2 : Removed blank lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1025 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D src/core/SkMatrixClipStateMgr.h View 1 chunk +0 lines, -406 lines 0 comments Download
D src/core/SkMatrixClipStateMgr.cpp View 1 chunk +0 lines, -419 lines 0 comments Download
M src/core/SkPictureRecord.h View 4 chunks +0 lines, -10 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 40 chunks +0 lines, -188 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 4 months ago (2014-08-11 12:53:22 UTC) #1
f(malita)
lgtm
6 years, 4 months ago (2014-08-11 12:55:38 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 4 months ago (2014-08-11 12:55:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/453133003/20001
6 years, 4 months ago (2014-08-11 12:56:30 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 13:03:47 UTC) #5
Message was sent while issue was closed.
Change committed as 6b143b080820c34c9c0f80e5c682939e9ee3879d

Powered by Google App Engine
This is Rietveld 408576698