Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 453133002: Mojo: Generalize blink::URLRequest -> mojo::URLRequest conversion, and use it (Closed)

Created:
6 years, 4 months ago by Matt Perry
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Generalize blink::URLRequest -> mojo::URLRequest conversion, and use it to initialize requests in WebURLLoaderImpl. BUG=394645 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289176

Patch Set 1 #

Total comments: 4

Patch Set 2 : darin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -89 lines) Patch
M mojo/mojo_services.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/services/html_viewer/blink_url_request_type_converters.h View 1 chunk +24 lines, -0 lines 0 comments Download
A mojo/services/html_viewer/blink_url_request_type_converters.cc View 1 chunk +110 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 1 3 chunks +2 lines, -85 lines 0 comments Download
M mojo/services/html_viewer/weburlloader_impl.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Matt Perry
6 years, 4 months ago (2014-08-08 22:34:26 UTC) #1
darin (slow to review)
LGTM w/ nit: https://codereview.chromium.org/453133002/diff/1/mojo/services/html_viewer/html_document_view.cc File mojo/services/html_viewer/html_document_view.cc (right): https://codereview.chromium.org/453133002/diff/1/mojo/services/html_viewer/html_document_view.cc#newcode169 mojo/services/html_viewer/html_document_view.cc:169: TypeConverter<URLRequestPtr, blink::WebURLRequest>::ConvertFrom(request); You can just use ...
6 years, 4 months ago (2014-08-12 16:23:12 UTC) #2
Matt Perry
https://codereview.chromium.org/453133002/diff/1/mojo/services/html_viewer/html_document_view.cc File mojo/services/html_viewer/html_document_view.cc (right): https://codereview.chromium.org/453133002/diff/1/mojo/services/html_viewer/html_document_view.cc#newcode169 mojo/services/html_viewer/html_document_view.cc:169: TypeConverter<URLRequestPtr, blink::WebURLRequest>::ConvertFrom(request); On 2014/08/12 16:23:12, darin wrote: > You ...
6 years, 4 months ago (2014-08-12 18:42:53 UTC) #3
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 4 months ago (2014-08-12 18:42:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/453133002/20001
6 years, 4 months ago (2014-08-12 18:44:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 23:58:55 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 03:12:57 UTC) #7
Message was sent while issue was closed.
Change committed as 289176

Powered by Google App Engine
This is Rietveld 408576698