Mojo: Generalize blink::URLRequest -> mojo::URLRequest conversion, and use it

mojo/services/html_viewer/weburlloader_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/services/html_viewer/weburlloader_impl.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/thread_task_runner_handle.h"
 #include "mojo/common/common_type_converters.h"
+#include "mojo/services/html_viewer/blink_url_request_type_converters.h"
 #include "mojo/services/public/interfaces/network/network_service.mojom.h"
 #include "net/base/net_errors.h"
 #include "third_party/WebKit/public/platform/WebURLError.h"
 #include "third_party/WebKit/public/platform/WebURLLoadTiming.h"
 #include "third_party/WebKit/public/platform/WebURLLoaderClient.h"
 #include "third_party/WebKit/public/platform/WebURLResponse.h"
 
 namespace mojo {
 namespace {
 
@@ skipping 37 matching lines @@
     blink::WebURLError& error,
     blink::WebData& data) {
   NOTIMPLEMENTED();
 }
 
 void WebURLLoaderImpl::loadAsynchronously(const blink::WebURLRequest& request,
                                           blink::WebURLLoaderClient* client) {
   client_ = client;
   url_ = request.url();
 
-  URLRequestPtr url_request(URLRequest::New());
-  url_request->url = String::From(url_);
-  url_request->method = request.httpMethod().utf8();
+  URLRequestPtr url_request =
+      TypeConverter<URLRequestPtr, blink::WebURLRequest>::ConvertFrom(request);

[darin (slow to review), 2014/08/12 16:23:12]

nit: URLRequest::From(request)

[Matt Perry, 2014/08/12 18:42:53]

Done.

   url_request->auto_follow_redirects = false;
-  // TODO(darin): Copy other fields.
 
   if (request.extraData()) {
     WebURLRequestExtraData* extra_data =
         static_cast<WebURLRequestExtraData*>(request.extraData());
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE,
         base::Bind(&WebURLLoaderImpl::OnReceivedResponse,
                    weak_factory_.GetWeakPtr(),
                    base::Passed(&extra_data->synthetic_response)));
   } else {
@@ skipping 103 matching lines @@
       MOJO_DEADLINE_INDEFINITE,
       base::Bind(&WebURLLoaderImpl::OnResponseBodyStreamReady,
                  weak_factory_.GetWeakPtr()));
 }
 
 void WebURLLoaderImpl::OnResponseBodyStreamReady(MojoResult result) {
   ReadMore();
 }
 
 }  // namespace mojo