Mojo: Generalize blink::URLRequest -> mojo::URLRequest conversion, and use it

mojo/services/html_viewer/html_document_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/services/html_viewer/html_document_view.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_util.h"
 #include "base/thread_task_runner_handle.h"
 #include "mojo/public/cpp/system/data_pipe.h"
 #include "mojo/services/html_viewer/blink_input_events_type_converters.h"
+#include "mojo/services/html_viewer/blink_url_request_type_converters.h"
 #include "mojo/services/html_viewer/webstoragenamespace_impl.h"
 #include "mojo/services/html_viewer/weburlloader_impl.h"
 #include "mojo/services/public/cpp/view_manager/node.h"
 #include "mojo/services/public/cpp/view_manager/view.h"
 #include "mojo/services/public/cpp/view_manager/view_observer.h"
 #include "skia/ext/refptr.h"
 #include "third_party/WebKit/public/platform/Platform.h"
 #include "third_party/WebKit/public/platform/WebHTTPHeaderVisitor.h"
 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebElement.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebScriptSource.h"
 #include "third_party/WebKit/public/web/WebSettings.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "third_party/skia/include/core/SkDevice.h"
 
 namespace mojo {
 namespace {
 
-// Ripped from web_url_loader_impl.cc. Why is everything so complicated?
-class HeaderFlattener : public blink::WebHTTPHeaderVisitor {
- public:
-  HeaderFlattener() : has_accept_header_(false) {}
-
-  virtual void visitHeader(const blink::WebString& name,
-                           const blink::WebString& value) {
-    // Headers are latin1.
-    const std::string& name_latin1 = name.latin1();
-    const std::string& value_latin1 = value.latin1();
-
-    // Skip over referrer headers found in the header map because we already
-    // pulled it out as a separate parameter.
-    if (LowerCaseEqualsASCII(name_latin1, "referer"))
-      return;
-
-    if (LowerCaseEqualsASCII(name_latin1, "accept"))
-      has_accept_header_ = true;
-
-    buffer_.push_back(name_latin1 + ": " + value_latin1);
-  }
-
-  Array<String> GetBuffer() {
-    // In some cases, WebKit doesn't add an Accept header, but not having the
-    // header confuses some web servers.  See bug 808613.
-    if (!has_accept_header_) {
-      buffer_.push_back("Accept: */*");
-      has_accept_header_ = true;
-    }
-    return buffer_.Pass();
-  }
-
- private:
-  Array<String> buffer_;
-  bool has_accept_header_;
-};
-
-void AddRequestBody(NavigationDetails* nav_details,
-                    const blink::WebURLRequest& request) {
-  if (request.httpBody().isNull())
-    return;
-
-  uint32_t i = 0;
-  blink::WebHTTPBody::Element element;
-  while (request.httpBody().elementAt(i++, element)) {
-    switch (element.type) {
-      case blink::WebHTTPBody::Element::TypeData:
-        if (!element.data.isEmpty()) {
-          // WebKit sometimes gives up empty data to append. These aren't
-          // necessary so we just optimize those out here.
-          uint32_t num_bytes = static_cast<uint32_t>(element.data.size());
-          MojoCreateDataPipeOptions options;
-          options.struct_size = sizeof(MojoCreateDataPipeOptions);
-          options.flags = MOJO_CREATE_DATA_PIPE_OPTIONS_FLAG_NONE;
-          options.element_num_bytes = 1;
-          options.capacity_num_bytes = num_bytes;
-          DataPipe data_pipe(options);
-          nav_details->request->body.push_back(
-              data_pipe.consumer_handle.Pass());
-          WriteDataRaw(data_pipe.producer_handle.get(),
-                       element.data.data(),
-                       &num_bytes,
-                       MOJO_WRITE_DATA_FLAG_ALL_OR_NONE);
-        }
-        break;
-      case blink::WebHTTPBody::Element::TypeFile:
-      case blink::WebHTTPBody::Element::TypeFileSystemURL:
-      case blink::WebHTTPBody::Element::TypeBlob:
-        // TODO(mpcomplete): handle these.
-        NOTIMPLEMENTED();
-        break;
-      default:
-        NOTREACHED();
-    }
-  }
-}
-
 void ConfigureSettings(blink::WebSettings* settings) {
   settings->setAcceleratedCompositingEnabled(false);
   settings->setCookieEnabled(true);
   settings->setDefaultFixedFontSize(13);
   settings->setDefaultFontSize(16);
   settings->setLoadsImagesAutomatically(true);
   settings->setJavaScriptEnabled(true);
 }
 
 Target WebNavigationPolicyToNavigationTarget(
@@ skipping 110 matching lines @@
 }
 
 blink::WebNavigationPolicy HTMLDocumentView::decidePolicyForNavigation(
     blink::WebLocalFrame* frame, blink::WebDataSource::ExtraData* data,
     const blink::WebURLRequest& request, blink::WebNavigationType nav_type,
     blink::WebNavigationPolicy default_policy, bool is_redirect) {
   if (CanNavigateLocally(frame, request))
     return default_policy;
 
   NavigationDetailsPtr nav_details(NavigationDetails::New());
-  nav_details->request->url = request.url().string().utf8();
-  nav_details->request->method = request.httpMethod().utf8();
-
-  HeaderFlattener flattener;
-  request.visitHTTPHeaderFields(&flattener);
-  nav_details->request->headers = flattener.GetBuffer().Pass();
-
-  AddRequestBody(nav_details.get(), request);
+  nav_details->request =
+      TypeConverter<URLRequestPtr, blink::WebURLRequest>::ConvertFrom(request);

[darin (slow to review), 2014/08/12 16:23:12]

You can just use URLRequest::From(request) here.

[Matt Perry, 2014/08/12 18:42:53]

Done.

 
   navigator_host_->RequestNavigate(
       view_->node()->id(),
       WebNavigationPolicyToNavigationTarget(default_policy),
       nav_details.Pass());
 
   return blink::WebNavigationPolicyIgnore;
 }
 
 void HTMLDocumentView::didAddMessageToConsole(
@@ skipping 43 matching lines @@
 
   skia::RefPtr<SkCanvas> canvas = skia::AdoptRef(SkCanvas::NewRaster(
       SkImageInfo::MakeN32(width, height, kOpaque_SkAlphaType)));
 
   web_view_->paint(canvas.get(), gfx::Rect(0, 0, width, height));
 
   view_->SetContents(canvas->getDevice()->accessBitmap(false));
 }
 
 }  // namespace mojo