Switch startTracing to use record-as-much-as-possible option.

Switch startTracing to use record-as-much-as-possible option.

BUG=396081
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288896

[nednguyen, 2014-08-08 20:04:49]

On 2014/08/08 17:58:21, nednguyen wrote:

I verify that this works on local by modify the trace_event_impl.cc to log the
buffer size info and then run telemetry test with
--extra-browser-args="--enable-logging --v=1".

[nduca, 2014-08-08 20:19:06]

https://codereview.chromium.org/453033002/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/453033002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:20: def
__init__(self, devtools_port, use_record_as_much_as_possible=False):
Please make the recording mode an TraceOptions field. You could make the default
value be as_much_as_possible then have the backend silently fall back to regular
in start.

[nednguyen, 2014-08-08 23:16:07]

https://codereview.chromium.org/453033002/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/453033002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:20: def
__init__(self, devtools_port, use_record_as_much_as_possible=False):
On 2014/08/08 20:19:06, nduca wrote:
> Please make the recording mode an TraceOptions field. You could make the
default
> value be as_much_as_possible then have the backend silently fall back to
regular
> in start.

Done.

[nednguyen, 2014-08-09 00:49:33]

On 2014/08/08 23:16:07, nednguyen wrote:
>
https://codereview.chromium.org/453033002/diff/40001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py
(right):
> 
>
https://codereview.chromium.org/453033002/diff/40001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:20: def
> __init__(self, devtools_port, use_record_as_much_as_possible=False):
> On 2014/08/08 20:19:06, nduca wrote:
> > Please make the recording mode an TraceOptions field. You could make the
> default
> > value be as_much_as_possible then have the backend silently fall back to
> regular
> > in start.
> 
> Done.

Please take a look again. I will make subsequent patch(es) to make sure that we
propagate TracingOption & TracingCategoryFilter through the whole stack and only
convert them to string inside tracing_backend.

[nduca, 2014-08-11 18:33:02]

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
(right):

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py:262:
event categories.
wordwrap

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py:271: if
not (self.chrome_branch_number and self.chrome_branch_number >= 2118):
can you move this to the tracing backend please?

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:20: def
__init__(self, devtools_port):
just construct this with a handle to the browser backend

[nednguyen, 2014-08-11 18:56:10]

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
(right):

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py:262:
event categories.
On 2014/08/11 18:33:02, nduca wrote:
> wordwrap

Done.

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py:271: if
not (self.chrome_branch_number and self.chrome_branch_number >= 2118):
On 2014/08/11 18:33:02, nduca wrote:
> can you move this to the tracing backend please?

Done.

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/453033002/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:20: def
__init__(self, devtools_port):
On 2014/08/11 18:33:02, nduca wrote:
> just construct this with a handle to the browser backend

Done.

[nduca, 2014-08-11 19:24:04]

lgtm with nit

https://codereview.chromium.org/453033002/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/453033002/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:66:
req['params']['options'] = trace_options.record_mode
nit: you're hard coding that the RECORD_x enum *values* are exaclty equal to the
strings. Can you have an inline dict

m = { trace_options_module.RECORD_UNTILL_FULL: 'record-until-full', 
  ... }

req['params']['options'] = m[trace_options.record_mode]

[nednguyen, 2014-08-11 21:03:43]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2014-08-11 21:04:29]

https://codereview.chromium.org/453033002/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/453033002/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:66:
req['params']['options'] = trace_options.record_mode
On 2014/08/11 19:24:04, nduca wrote:
> nit: you're hard coding that the RECORD_x enum *values* are exaclty equal to
the
> strings. Can you have an inline dict
> 
> m = { trace_options_module.RECORD_UNTILL_FULL: 'record-until-full', 
>   ... }
> 
> req['params']['options'] = m[trace_options.record_mode]

Done.

[commit-bot: I haz the power, 2014-08-11 21:06:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/453033002/140001

[commit-bot: I haz the power, 2014-08-12 00:17:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-12 00:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 00:43:38]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[nednguyen, 2014-08-12 03:01:10]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-08-12 03:04:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/453033002/140001

[commit-bot: I haz the power, 2014-08-12 03:20:05]

Change committed as 288896