tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py - Issue 453033002: Switch startTracing to use record-as-much-as-possible option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py

Issue 453033002: Switch startTracing to use record-as-much-as-possible option. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Nat's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py ('k') | tools/telemetry/telemetry/core/platform/tracing_controller_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py

index 58d8d4283a6207fb2a9399edad841fda0e4fd54b..089b0388e0f2e5e0d86e14c2dfdc1f7062865497 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py

@@ -5,6 +5,7 @@

import codecs

from telemetry.core.platform import profiler

+from telemetry.core.platform import tracing_options

class TraceProfiler(profiler.Profiler):

@@ -18,7 +19,10 @@ class TraceProfiler(profiler.Profiler):

categories_with_flow = 'disabled-by-default-toplevel.flow'

if categories:

categories_with_flow = ',%s' % categories

- self._browser_backend.StartTracing(categories_with_flow, timeout=10)

+ options = tracing_options.TracingOptions()

+ options.enable_chrome_trace = True

+ self._browser_backend.StartTracing(

+ options, categories_with_flow, timeout=10)

@classmethod

def name(cls):