tools/telemetry/telemetry/core/backends/browser_backend.py - Issue 453033002: Switch startTracing to use record-as-much-as-possible option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/browser_backend.py

Issue 453033002: Switch startTracing to use record-as-much-as-possible option. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Nat's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/browser_backend.py b/tools/telemetry/telemetry/core/backends/browser_backend.py

index ec9786746704ed4b9c1d959c1bcd9a767add111e..0cdae0a5a2a1a8101237e855f584a043938dd1fa 100644

--- a/tools/telemetry/telemetry/core/backends/browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/browser_backend.py

@@ -69,7 +69,7 @@ class BrowserBackend(object):

self._forwarder_factory = do_nothing_forwarder.DoNothingForwarderFactory()

return self._forwarder_factory

- def StartTracing(self, custom_categories=None,

+ def StartTracing(self, trace_options, custom_categories=None,

timeout=web_contents.DEFAULT_WEB_CONTENTS_TIMEOUT):

raise NotImplementedError()

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »