Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 452983002: SkRecord: Strip out cull-skipping and y-only drawPosTextH skipping. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkRecord: Strip out cull-skipping and y-only drawPosTextH skipping. These optimizations are outclassed by a general bounding-box hierarchy, and are just going to make plugging that into SkRecordDraw more complicated. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f4078ad1ec42f549369ac4f639aab18d00afae95

Patch Set 1 #

Patch Set 2 : Remove dead code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -286 lines) Patch
M src/core/SkRecordDraw.h View 1 chunk +1 line, -13 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M src/core/SkRecordOpts.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/core/SkRecordOpts.cpp View 3 chunks +0 lines, -104 lines 0 comments Download
M src/core/SkRecords.h View 3 chunks +1 line, -7 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 2 chunks +0 lines, -66 lines 0 comments Download
M tests/RecordOptsTest.cpp View 2 chunks +0 lines, -72 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
6 years, 4 months ago (2014-08-08 16:49:46 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-08 16:50:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/452983002/1
6 years, 4 months ago (2014-08-08 16:50:30 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-08 16:50:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-08-08 16:57:09 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-08 16:58:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/452983002/20001
6 years, 4 months ago (2014-08-08 16:58:59 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-08 16:59:01 UTC) #8
robertphillips
lgtm
6 years, 4 months ago (2014-08-08 17:01:11 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 17:05:26 UTC) #10
Message was sent while issue was closed.
Change committed as f4078ad1ec42f549369ac4f639aab18d00afae95

Powered by Google App Engine
This is Rietveld 408576698