Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 452793002: Export WebSecurityOrigin's secure origin check. (Closed)

Created:
6 years, 4 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 4 months ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr, palmer
Project:
blink
Visibility:
Public.

Description

Export WebSecurityOrigin's secure origin check. Service Worker needs to enforce the canAccessFeatureRequiringSecureOrigin check in content/browser. Exporting the symbol so the embedder can link to it. This is follow-up to r179341. BUG=362214 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M public/web/WebSecurityOrigin.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dominicc (has gone to gerrit)
PTAL Think actually exporting the symbol was missed in https://codereview.chromium.org/428643007
6 years, 4 months ago (2014-08-08 07:13:36 UTC) #1
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-08 15:37:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/452793002/1
6 years, 4 months ago (2014-08-08 15:37:26 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 16:39:41 UTC) #4
Message was sent while issue was closed.
Change committed as 179843

Powered by Google App Engine
This is Rietveld 408576698