Add WebSecurityOrigin::CanAccessFeatureRequiringSecureOrigin.

Add WebSecurityOrigin::CanAccessFeatureRequiringSecureOrigin.

Exposes |SecurityOrigin::canAccessFeatureRequiringSecureOrigin| to
embedders such as Chromium.

BUG=362214
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179341

[palmer, 2014-07-29 18:40:24]

OK, I think this is the better way to go. PTAL. Thank you!

[jochen (gone - plz use gerrit), 2014-07-29 19:02:47]

btw, have you verified that you can actually include this header from where you
want to use it?

https://codereview.chromium.org/428643007/diff/1/Source/web/WebSecurityOrigin...
File Source/web/WebSecurityOrigin.cpp (right):

https://codereview.chromium.org/428643007/diff/1/Source/web/WebSecurityOrigin...
Source/web/WebSecurityOrigin.cpp:116: WTF::String message(errorMessage);
is this required? The WebString should be automatically converted to a WTF
string, no?

[palmer, 2014-07-29 21:35:03]

On 2014/07/29 19:02:47, jochen wrote:

> btw, have you verified that you can actually include this header from where
you
> want to use it?

Yes, e.g. the Service Worker code already includes it.

>
https://codereview.chromium.org/428643007/diff/1/Source/web/WebSecurityOrigin...
> Source/web/WebSecurityOrigin.cpp:116: WTF::String message(errorMessage);
> is this required? The WebString should be automatically converted to a WTF
> string, no?

No; when I change to not using the intermediate value, I get this:

../../third_party/WebKit/Source/web/WebSecurityOrigin.cpp:116:61: error:
non-const lvalue reference to type 'WTF::String' cannot bind to a value of
unrelated type 'blink::WebString'
    return m_private->canAccessFeatureRequiringSecureOrigin(errorMessage);
                                                            ^~~~~~~~~~~~
../../third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h:121:56:
note: passing argument to parameter 'errorMessage' here
    bool canAccessFeatureRequiringSecureOrigin(String& errorMessage) const;

There seems to be an easy conversion from |const WebString&| to |const
(WTF::)String&| in Blink — that conversion is used elsewhere in
WebSecurityOrigin.cpp — but non-const to non-const isn't happening.

(I had to change bool canAccessFeatureRequiringSecureOrigin(const WebString&
errorMessage) const; to bool canAccessFeatureRequiringSecureOrigin(WebString&
errorMessage) const; because: additionally,
|SecurityOrigin::canAccessFeatureRequiringSecureOrigin| uses |errorMessage| as
an out-param (I hate non-const references!), but that also means I need to
enable the same behavior in
|WebSecurityOrigin::canAccessFeatureRequiringSecureOrigin|. In Patch Set 1 I was
causing a side-effect on the intermediary value and then throwing it away!)

So, some API ugliness here.

[eroman, 2014-07-29 22:41:12]

patchset2 lgtm

[jochen (gone - plz use gerrit), 2014-07-30 09:44:50]

lgtm

[palmer, 2014-07-31 18:24:11]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2014-07-31 18:25:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/palmer@chromium.org/428643007/20001

[commit-bot: I haz the power, 2014-07-31 19:28:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[commit-bot: I haz the power, 2014-07-31 19:52:06]

Change committed as 179341