Use a qualified path for grit includes in various chrome/ directories.

Use a qualified path for grit includes in various chrome/ directories.

BUG=401588
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289213

[Lei Zhang, 2014-08-08 01:43:59]

kalman: extensions bits
piman: chrome/renderer/plugins
blundell: the rest

[piman, 2014-08-08 03:07:51]

lgtm

[blundell, 2014-08-08 06:12:23]

blundell -> thestig

I'm not an OWNER of any of the affected code

[Lei Zhang, 2014-08-08 06:51:46]

On 2014/08/08 06:12:23, blundell wrote:
> blundell -> thestig

I can't give myself a L G

> I'm not an OWNER of any of the affected code

chrome/utility/importer/DEPS now have dependencies on components, so I need a
component owner to accept the "new" dependency.

[blundell, 2014-08-08 06:52:57]

On 2014/08/08 06:51:46, Lei Zhang wrote:
> On 2014/08/08 06:12:23, blundell wrote:
> > blundell -> thestig
> 
> I can't give myself a L G

heh. I had misread this CL as being from Thiago for some reason.

> 
> > I'm not an OWNER of any of the affected code
> 
> chrome/utility/importer/DEPS now have dependencies on components, so I need a
> component owner to accept the "new" dependency.

[blundell, 2014-08-08 06:56:39]

lgtm

[not at google - send to devlin, 2014-08-08 13:55:54]

lgtm

https://codereview.chromium.org/450053003/diff/1/chrome/common/extensions/chr...
File chrome/common/extensions/chrome_extensions_client.cc (right):

https://codereview.chromium.org/450053003/diff/1/chrome/common/extensions/chr...
chrome/common/extensions/chrome_extensions_client.cc:39: #if
defined(ENABLE_EXTENSIONS)
i presume that eventually this'll be unnecessary because
chrome_extensions_client won't even be installed if ENABLE_EXTENSIONS is false?

[Lei Zhang, 2014-08-08 19:10:50]

https://codereview.chromium.org/450053003/diff/1/chrome/common/extensions/chr...
File chrome/common/extensions/chrome_extensions_client.cc (right):

https://codereview.chromium.org/450053003/diff/1/chrome/common/extensions/chr...
chrome/common/extensions/chrome_extensions_client.cc:39: #if
defined(ENABLE_EXTENSIONS)
On 2014/08/08 13:55:54, kalman wrote:
> i presume that eventually this'll be unnecessary because
> chrome_extensions_client won't even be installed if ENABLE_EXTENSIONS is
false?

Yes, but we are not quite there yet. Only chrome/browser/extensions and
extensions/browser are completely switched off on Android right now.

[Lei Zhang, 2014-08-08 19:10:57]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-08 19:12:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/450053003/1

[commit-bot: I haz the power, 2014-08-08 23:42:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-08 23:46:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 23:46:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2014-08-09 00:01:44]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-09 00:04:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/450053003/40001

[commit-bot: I haz the power, 2014-08-09 08:35:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-09 08:40:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-09 08:40:38]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Lei Zhang, 2014-08-11 21:49:12]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-11 21:51:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/450053003/80001

[commit-bot: I haz the power, 2014-08-12 01:24:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40268)
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2014-08-12 01:39:59]

The CQ bit was unchecked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-12 01:43:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 01:43:29]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40301)
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2014-08-12 01:48:17]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-12 01:56:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/450053003/100001

[Lei Zhang, 2014-08-12 03:22:00]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-08-13 05:15:14]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-13 05:16:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/450053003/120001

[commit-bot: I haz the power, 2014-08-13 08:28:35]

Change committed as 289213