chrome/common/extensions/api/extension_action/browser_action_handler.cc - Issue 450053003: Use a qualified path for grit includes in various chrome/ directories.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/api/extension_action/browser_action_handler.cc

Issue 450053003: Use a qualified path for grit includes in various chrome/ directories. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove webkit strings that no longer exist Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc ('k') | chrome/common/extensions/api/extension_action/page_action_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h "	5 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h "

6	6

7 #include "base/memory/scoped_ptr.h"	7 #include "base/memory/scoped_ptr.h"

8 #include "base/strings/utf_string_conversions.h"	8 #include "base/strings/utf_string_conversions.h"

9 #include "base/values.h"	9 #include "base/values.h"

	10 #include "chrome/grit/generated_resources.h"

10 #include "extensions/common/extension.h"	11 #include "extensions/common/extension.h"

11 #include "extensions/common/feature_switch.h"	12 #include "extensions/common/feature_switch.h"

12 #include "extensions/common/file_util.h"	13 #include "extensions/common/file_util.h"

13 #include "extensions/common/manifest.h"	14 #include "extensions/common/manifest.h"

14 #include "extensions/common/manifest_constants.h"	15 #include "extensions/common/manifest_constants.h"

15 #include "grit/generated_resources.h"

16	16

17 namespace extensions {	17 namespace extensions {

18	18

19 BrowserActionHandler::BrowserActionHandler() {	19 BrowserActionHandler::BrowserActionHandler() {

20 }	20 }

21	21

22 BrowserActionHandler::~BrowserActionHandler() {	22 BrowserActionHandler::~BrowserActionHandler() {

23 }	23 }

24	24

25 bool BrowserActionHandler::Parse(Extension* extension,	25 bool BrowserActionHandler::Parse(Extension* extension,

(...skipping 28 matching lines...) Expand all Loading...
54 return false;	54 return false;

55 }	55 }

56 return true;	56 return true;

57 }	57 }

58	58

59 const std::vector<std::string> BrowserActionHandler::Keys() const {	59 const std::vector<std::string> BrowserActionHandler::Keys() const {

60 return SingleKey(manifest_keys::kBrowserAction);	60 return SingleKey(manifest_keys::kBrowserAction);

61 }	61 }

62	62

63 } // namespace extensions	63 } // namespace extensions

OLD	NEW