Converted the tryserver.chromium.linux asan builder to a recipe.

Converted the tryserver.chromium.linux asan builder to a recipe.

BUG=399729

[cmumford, 2014-08-08 21:12:47]

https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
File masters/master.tryserver.chromium/master.cfg (left):

https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
masters/master.tryserver.chromium/master.cfg:1301: 'sharded_tests':
sharded_tests,
Note: I can't see a place to put these values in the recipe, and I'm not sure
they are still needed. Can a reviewer make a suggestion?

[Michael Achenbach, 2014-08-09 07:57:35]

There seems to be some effort to merge the chromium and chromium_trybot recipe
which I didn't know of https://codereview.chromium.org/413223003

@iannucci,agable: Where to put new chromium trybots? Should they use chromium.py
or chromium_trybot.py?

My gut feeling: Make everything as similar to linux_chromium_rel as possible.
I.e. use chromium_trybot.py recipe for now.

Another strong recommendation: Split the master.cfg change from the rest. The
recipe stuff can land first and in peace. Landing the master.cfg change requires
a tryserver restart and needs to be coordinated by a trooper. You don't wan't to
deal with too much rebasing then.

https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
File masters/master.tryserver.chromium/master.cfg (left):

https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
masters/master.tryserver.chromium/master.cfg:1301: 'sharded_tests':
sharded_tests,
asan and lsan are now defined through gyp. The cluster_size is leading to a
batch size cmd line flag, which is now set in the chromium_asan recipe config.

I'm not sure about the sharded tests list these days - but I didn't see it for
"normal" linux recipes either.

https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
File masters/master.tryserver.chromium/master.cfg (right):

https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
masters/master.tryserver.chromium/master.cfg:1232: 'factory':
m_annotator.BaseFactory('chromium_asan'),
Here should go the recipe name. Right now you use "chromium" but it probably
should be "chromium_trybot".

https://codereview.chromium.org/449993005/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py (right):

https://codereview.chromium.org/449993005/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py:17:
'compile_targets': [
Look at how chromium_linux_rel is defined:
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...

I don't think you need the compile targets or any tests here. They're all
dynamically calculated. You'll need a chromium-side spec file that lands first -
like this:
http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_try...
or this:
http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/tryserver.ch...

[iannucci, 2014-08-09 17:22:32]

On 2014/08/09 07:57:35, Michael Achenbach wrote:
> There seems to be some effort to merge the chromium and chromium_trybot recipe
> which I didn't know of https://codereview.chromium.org/413223003
> 
> @iannucci,agable: Where to put new chromium trybots? Should they use
chromium.py
> or chromium_trybot.py?
> 
> My gut feeling: Make everything as similar to linux_chromium_rel as possible.
> I.e. use chromium_trybot.py recipe for now.
> 

I think that's a good question for Pawel, though I would be inclined to do what
you suggest (mirror linux_chromium_rel). If there's a conversion effort, then
yours will get converted along with the rest.

> Another strong recommendation: Split the master.cfg change from the rest. The
> recipe stuff can land first and in peace. Landing the master.cfg change
requires
> a tryserver restart and needs to be coordinated by a trooper. You don't wan't
to
> deal with too much rebasing then.

Good idea

> 
>
https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
> File masters/master.tryserver.chromium/master.cfg (left):
> 
>
https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
> masters/master.tryserver.chromium/master.cfg:1301: 'sharded_tests':
> sharded_tests,
> asan and lsan are now defined through gyp. The cluster_size is leading to a
> batch size cmd line flag, which is now set in the chromium_asan recipe config.
> 
> I'm not sure about the sharded tests list these days - but I didn't see it for
> "normal" linux recipes either.
> 
>
https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
> File masters/master.tryserver.chromium/master.cfg (right):
> 
>
https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
> masters/master.tryserver.chromium/master.cfg:1232: 'factory':
> m_annotator.BaseFactory('chromium_asan'),
> Here should go the recipe name. Right now you use "chromium" but it probably
> should be "chromium_trybot".
> 
>
https://codereview.chromium.org/449993005/diff/1/scripts/slave/recipe_modules...
> File scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py
(right):
> 
>
https://codereview.chromium.org/449993005/diff/1/scripts/slave/recipe_modules...
> scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py:17:
> 'compile_targets': [
> Look at how chromium_linux_rel is defined:
>
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...
> 
> I don't think you need the compile targets or any tests here. They're all
> dynamically calculated. You'll need a chromium-side spec file that lands first
-
> like this:
>
http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_try...
> or this:
>
http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/tryserver.ch...

[Paweł Hajdan Jr., 2014-08-11 10:01:23]

https://codereview.chromium.org/449993005/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py (right):

https://codereview.chromium.org/449993005/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py:17:
'compile_targets': [
On 2014/08/09 07:57:35, Michael Achenbach wrote:
> Look at how chromium_linux_rel is defined:
>
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...

Yes, please use chromium_trybot recipe, *not* the chromium recipe.

> I don't think you need the compile targets or any tests here. They're all
> dynamically calculated. You'll need a chromium-side spec file that lands first
-
> like this:
>
http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_try...

This - alternatively feel free to create another spec file for the memory
trybots, e.g. chromium_memory_trybot.json. There is an existing infrastructure
to make chromium_trybot recipe use a different spec file.

[cmumford, 2014-08-13 17:17:07]

https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
File masters/master.tryserver.chromium/master.cfg (right):

https://codereview.chromium.org/449993005/diff/1/masters/master.tryserver.chr...
masters/master.tryserver.chromium/master.cfg:1232: 'factory':
m_annotator.BaseFactory('chromium_asan'),
On 2014/08/09 07:57:35, Michael Achenbach wrote:
> Here should go the recipe name. Right now you use "chromium" but it probably
> should be "chromium_trybot".

So I'm confused by your comment because I wasn't using "chromium" - I was using
"chromium_asan". I did switch to "chromium_trybot" because I misunderstood
Pawel's comment below in tryserver_chromium_linux.py which didn't seem to have
any effect.

https://codereview.chromium.org/449993005/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py (right):

https://codereview.chromium.org/449993005/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py:17:
'compile_targets': [
On 2014/08/11 10:01:23, Paweł Hajdan Jr. wrote:
> On 2014/08/09 07:57:35, Michael Achenbach wrote:
> > Look at how chromium_linux_rel is defined:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...
> 
> Yes, please use chromium_trybot recipe, *not* the chromium recipe.
> 
> > I don't think you need the compile targets or any tests here. They're all
> > dynamically calculated. You'll need a chromium-side spec file that lands
first
> -
> > like this:
> >
>
http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_try...
> 
> This - alternatively feel free to create another spec file for the memory
> trybots, e.g. chromium_memory_trybot.json. There is an existing infrastructure
> to make chromium_trybot recipe use a different spec file.

Thanks Pawel. I've created a new chromium_memory_trybot.json file because
original asan tests only ran 27 tests, but chromium.memory.json runs 69.
chromium.memory.json is a superset of linux_asan (i.e. all tests are included),
but I just want to make a lateral move over to a recipe and not triple the tests
that are run.

https://codereview.chromium.org/464063004/

When/if that lands can you instruct me how to reference it in by this recipe?

[Paweł Hajdan Jr., 2014-08-14 11:25:39]

For how to use an alternative spec file, please look for 'test_spec_file':
'chromium_arm.json' in chromium_trybot.py

https://codereview.chromium.org/449993005/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/builders.py (right):

https://codereview.chromium.org/449993005/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/builders.py:34:
'tryserver.chromium.linux': tryserver_chromium_linux.SPEC,
This shouldn't be needed. chromium_trybot does not use this.

https://codereview.chromium.org/449993005/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py (right):

https://codereview.chromium.org/449993005/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py:7: SPEC = {
This shouldn't be needed. chromium_trybot does not use this.

[cmumford, 2014-08-26 16:00:43]

Made suggested changes. BTW I can't yet run this recipe locally. Just pushing up
for review/comment.

https://codereview.chromium.org/449993005/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py (right):

https://codereview.chromium.org/449993005/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py:7: SPEC = {
On 2014/08/14 11:25:39, Paweł Hajdan Jr. wrote:
> This shouldn't be needed. chromium_trybot does not use this.

Done.

[Paweł Hajdan Jr., 2014-08-26 16:27:21]

https://codereview.chromium.org/449993005/diff/40001/masters/master.tryserver...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/449993005/diff/40001/masters/master.tryserver...
masters/master.tryserver.chromium.linux/master.cfg:832: 'factory':
m_annotator.BaseFactory('chromium_trybot'),
Please add a new bot instead of replacing the existing one.

Also, split master-side change to a separate CL from recipe-side one.

https://codereview.chromium.org/449993005/diff/40001/scripts/slave/recipes/ch...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/449993005/diff/40001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:94: 'linux_asan': {
The builder name should match above pattern and the master config.

Please make it 'linux_chromium_asan_rel'.

[Michael Achenbach, 2014-08-28 08:23:44]

Guess this is obsolete now and can be closed?