scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py - Issue 449993005: Converted the tryserver.chromium.linux asan builder to a recipe.

Side by Side Diff: scripts/slave/recipe_modules/chromium/tryserver_chromium_linux.py

Issue 449993005: Converted the tryserver.chromium.linux asan builder to a recipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« masters/master.tryserver.chromium/master.cfg ('K') | « scripts/slave/recipe_modules/chromium/builders.py ('k') | scripts/slave/recipes/chromium.expected/full_tryserver_chromium_linux_Linux_ASan_LSan_Builder.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from . import steps

	6

	7 SPEC = {

	8 'builders': {

	9 'Linux ASan LSan Builder': {

	10 'recipe_config': 'chromium_asan',

	11 'chromium_config_kwargs': {

	12 'BUILD_CONFIG': 'Release',

	13 'TARGET_BITS': 64,

	14 },

	15 'bot_type': 'builder_tester',

	16 'testing': {'platform': 'linux'},

	17 'compile_targets': [
	Michael Achenbach 2014/08/09 07:57:35 Look at how chromium_linux_rel is defined: https:/ Look at how chromium_linux_rel is defined: https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl... I don't think you need the compile targets or any tests here. They're all dynamically calculated. You'll need a chromium-side spec file that lands first - like this: http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_try... or this: http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/tryserver.ch... Paweł Hajdan Jr. 2014/08/11 10:01:23 Yes, please use chromium_trybot recipe, not the Show quoted text On 2014/08/09 07:57:35, Michael Achenbach wrote: > Look at how chromium_linux_rel is defined: > https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl... Yes, please use chromium_trybot recipe, not the chromium recipe. Show quoted text > I don't think you need the compile targets or any tests here. They're all > dynamically calculated. You'll need a chromium-side spec file that lands first - > like this: > http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_try... This - alternatively feel free to create another spec file for the memory trybots, e.g. chromium_memory_trybot.json. There is an existing infrastructure to make chromium_trybot recipe use a different spec file. cmumford 2014/08/13 17:17:07 Thanks Pawel. I've created a new chromium_memory_t Show quoted text On 2014/08/11 10:01:23, Paweł Hajdan Jr. wrote: > On 2014/08/09 07:57:35, Michael Achenbach wrote: > > Look at how chromium_linux_rel is defined: > > > https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl... > > Yes, please use chromium_trybot recipe, not the chromium recipe. > > > I don't think you need the compile targets or any tests here. They're all > > dynamically calculated. You'll need a chromium-side spec file that lands first > - > > like this: > > > http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_try... > > This - alternatively feel free to create another spec file for the memory > trybots, e.g. chromium_memory_trybot.json. There is an existing infrastructure > to make chromium_trybot recipe use a different spec file. Thanks Pawel. I've created a new chromium_memory_trybot.json file because original asan tests only ran 27 tests, but chromium.memory.json runs 69. chromium.memory.json is a superset of linux_asan (i.e. all tests are included), but I just want to make a lateral move over to a recipe and not triple the tests that are run. https://codereview.chromium.org/464063004/ When/if that lands can you instruct me how to reference it in by this recipe?
	18 'accessibility_unittests',

	19 'base_unittests',

	20 'cacheinvalidation_unittests',

	21 'cast_unittests',

	22 'cc_unittests',

	23 'components_unittests',

	24 'content_unittests',

	25 'crypto_unittests',

	26 'device_unittests',

	27 'display_unittests',

	28 'gcm_unit_tests',

	29 'gfx_unittests',

	30 'google_apis_unittests',

	31 'gpu_unittests',

	32 'ipc_tests',

	33 'jingle_unittests',

	34 'media_unittests',

	35 'net_unittests',

	36 'ppapi_unittests',

	37 'printing_unittests',

	38 'remoting_unittests',

	39 'sandbox_linux_unittests',

	40 'sql_unittests',

	41 'sync_unit_tests',

	42 'ui_unittests',

	43 'unit_tests',

	44 'url_unittests',

	45 ],

	46 'tests': [

	47 steps.ArchiveBuildStep(

	48 'chromium-browser-snapshots',

	49 gs_acl='public-read',

	50 ),

	51 steps.Deps2GitTest(),

	52 steps.CheckpermsTest(),

	53 ],

	54 'testing': {

	55 'platform': 'linux',

	56 },

	57 },

	58 },

	59 }

	60

OLD	NEW