Converted the tryserver.chromium.linux asan builder to a recipe.

masters/master.tryserver.chromium/master.cfg

 # -*- python -*-
 # ex: set syntax=python:
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # READ THIS:
 # See http://dev.chromium.org/developers/testing/chromium-build-infrastructure
 
 import os
@@ skipping 1211 matching lines @@
     ],
     goma=True,
     factory_properties={
       'gclient_env': {
         'GYP_DEFINES': 'use_aura=1',
       },
     })
 
 b_linux_asan = {
   'name': 'linux_asan',
-  'factory': m_chromium_linux.ChromiumASANFactory(
-      slave_type='Trybot',
-      options=[
-        '--build-tool=ninja',
-        '--compiler=goma-clang',
-        'accessibility_unittests',
-        'base_unittests',
-        'cacheinvalidation_unittests',
-        'cast_unittests',
-        'cc_unittests',
-        'components_unittests',
-        'content_unittests',
-        'crypto_unittests',
-        'device_unittests',
-        'display_unittests',
-        'gcm_unit_tests',
-        'gfx_unittests',
-        'google_apis_unittests',
-        'gpu_unittests',
-        'ipc_tests',
-        'jingle_unittests',
-        'media_unittests',
-        'net_unittests',
-        'ppapi_unittests',
-        'printing_unittests',
-        'remoting_unittests',
-        'sandbox_linux_unittests',
-        'sql_unittests',
-        'sync_unit_tests',
-        'ui_unittests',
-        'unit_tests',
-        'url_unittests',
-      ],
-      tests=[
-        'accessibility_unittests',
-        'base_unittests',
-        'cacheinvalidation_unittests',
-        'cc_unittests',
-        'components_unittests',
-        'content_unittests',
-        'crypto_unittests',
-        'device_unittests',
-        'display_unittests',
-        'gcm_unit_tests',
-        'gfx_unittests',
-        'google_apis_unittests',
-        'gpu',
-        'ipc_tests',
-        'jingle',
-        'media',
-        'net',
-        'ppapi_unittests',
-        'printing',
-        'remoting',
-        'sandbox_linux_unittests',
-        'sql_unittests',
-        'sync_unit_tests',
-        'ui_unittests',
-        'unit_tests',
-        'url_unittests',
-      ],
-      factory_properties={
-        'asan': True,  # Used by runtest.py.
-        'cluster_size': 1,
-        'gclient_env': {
-          'GYP_GENERATORS': 'ninja',
-          'GYP_DEFINES': 'asan=1 lsan=1 use_allocator=none fastbuild=0',
-        },
-        'lsan': True,
-        'sharded_tests': sharded_tests,

[cmumford, 2014/08/08 21:12:47]

Note: I can't see a place to put these values in the recipe, and I'm not sure
they are still needed. Can a reviewer make a suggestion?

[Michael Achenbach, 2014/08/09 07:57:35]

asan and lsan are now defined through gyp. The cluster_size is leading to a
batch size cmd line flag, which is now set in the chromium_asan recipe config.

I'm not sure about the sharded tests list these days - but I didn't see it for
"normal" linux recipes either.

-      }),
+  'factory': m_annotator.BaseFactory('chromium_asan'),

[Michael Achenbach, 2014/08/09 07:57:35]

Here should go the recipe name. Right now you use "chromium" but it probably
should be "chromium_trybot".

[cmumford, 2014/08/13 17:17:07]

So I'm confused by your comment because I wasn't using "chromium" - I was using
"chromium_asan". I did switch to "chromium_trybot" because I misunderstood
Pawel's comment below in tryserver_chromium_linux.py which didn't seem to have
any effect.

 }
 
 b_linux_browser_asan = {
   'name': 'linux_browser_asan',
   'factory': m_chromium_linux.ChromiumASANFactory(
       slave_type='Trybot',
       options=[
         '--build-tool=ninja',
         '--compiler=goma-clang',
         'browser_tests',
@@ skipping 499 matching lines @@
 #  base.make_stop_form = hack_stop(base.make_stop_form)
 
 
 ####### PROJECT IDENTITY
 
 # The 'projectURL' string will be used to provide a link
 # from buildbot HTML pages to your project's home page.
 c['projectURL'] = 'http://dev.chromium.org/developers/testing/try-server-usage'
 
 # vi: set ts=4 sts=2 sw=2 et: