Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 449963002: Modify all usage of PageMeasurement to use PageTest in tools/telemetry. (Closed)

Created:
6 years, 4 months ago by chrishenry
Modified:
6 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Modify all usage of PageMeasurement to use PageTest in tools/telemetry. Also modify MeasurePage -> ValidateAndMeasurePage. BUG=383635 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288510

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -75 lines) Patch
M tools/telemetry/telemetry/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/benchmark.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 9 chunks +11 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/profile_creator.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 3 chunks +4 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 3 chunks +3 lines, -3 lines 0 comments Download
D tools/telemetry/unittest_data/page_measurements/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/telemetry/unittest_data/page_measurements/page_measurement1.py View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/telemetry/unittest_data/page_measurements/page_measurement2.py View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/telemetry/unittest_data/page_measurements/page_measurement3.py View 1 chunk +0 lines, -14 lines 0 comments Download
A + tools/telemetry/unittest_data/page_tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/unittest_data/page_tests/page_test1.py View 1 chunk +14 lines, -0 lines 0 comments Download
A tools/telemetry/unittest_data/page_tests/page_test2.py View 1 chunk +14 lines, -0 lines 0 comments Download
A tools/telemetry/unittest_data/page_tests/page_test3.py View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
chrishenry
Assuming ValidateOrMeasurePage in the other patch is OK (otherwise, I'll just sed them again).
6 years, 4 months ago (2014-08-07 20:19:42 UTC) #1
nednguyen
On 2014/08/07 20:19:42, chrishenry wrote: > Assuming ValidateOrMeasurePage in the other patch is OK (otherwise, ...
6 years, 4 months ago (2014-08-08 03:15:09 UTC) #2
chrishenry
On 2014/08/08 03:15:09, nednguyen wrote: > On 2014/08/07 20:19:42, chrishenry wrote: > > Assuming ValidateOrMeasurePage ...
6 years, 4 months ago (2014-08-08 13:58:09 UTC) #3
nednguyen
lgtm
6 years, 4 months ago (2014-08-08 14:53:41 UTC) #4
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 4 months ago (2014-08-08 18:07:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/449963002/40001
6 years, 4 months ago (2014-08-08 18:10:03 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 05:31:57 UTC) #7
Message was sent while issue was closed. 
Change committed as 288510

Powered by Google App Engine
This is Rietveld 408576698