tools/telemetry/telemetry/page/record_wpr_unittest.py - Issue 449963002: Modify all usage of PageMeasurement to use PageTest in tools/telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/record_wpr_unittest.py

Issue 449963002: Modify all usage of PageMeasurement to use PageTest in tools/telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr.py ('k') | tools/telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/record_wpr_unittest.py

diff --git a/tools/telemetry/telemetry/page/record_wpr_unittest.py b/tools/telemetry/telemetry/page/record_wpr_unittest.py

index 3da7384a5477a9bc5e860fb918f2720ba1717f83..61e9b7bf3bd726ddb4863eb979a7bde93470add6 100644

--- a/tools/telemetry/telemetry/page/record_wpr_unittest.py

+++ b/tools/telemetry/telemetry/page/record_wpr_unittest.py

@@ -87,7 +87,7 @@ class MockBenchmark(benchmark.Benchmark):

class RecordWprUnitTests(tab_test_case.TabTestCase):

_base_dir = util.GetUnittestDataDir()

- _test_data_dir = os.path.join(util.GetUnittestDataDir(), 'page_measurements')

+ _test_data_dir = os.path.join(util.GetUnittestDataDir(), 'page_tests')

@classmethod

def setUpClass(cls):

@@ -183,7 +183,7 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

wpr_recorder.options.browser_options.wpr_mode)

def testFindAllActionNames(self):

- # The src/tools/telemetry/unittest_data/page_measurements/ has been

+ # The src/tools/telemetry/unittest_data/page_tests/ has been

# populated with three simple Page Measurement classes, the first two of

# which have action_name_to_run defined.

action_names_to_run = record_wpr.FindAllActionNames(self._test_data_dir)

« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr.py ('k') | tools/telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »