tools/telemetry/telemetry/web_perf/timeline_based_measurement.py - Issue 449963002: Modify all usage of PageMeasurement to use PageTest in tools/telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 449963002: Modify all usage of PageMeasurement to use PageTest in tools/telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr_unittest.py ('k') | tools/telemetry/unittest_data/page_measurements/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

index e6050955a85b337a01a070c1bd9143dd727768a3..9268d33b669dd5438db6bda19b8744552b3703ad 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

@@ -13,7 +13,7 @@ from telemetry.web_perf import timeline_interaction_record as tir_module

from telemetry.web_perf.metrics import fast_metric

from telemetry.web_perf.metrics import responsiveness_metric

from telemetry.web_perf.metrics import smoothness

-from telemetry.page import page_measurement

+from telemetry.page import page_test

from telemetry.value import string as string_value_module

@@ -112,7 +112,7 @@ class _TimelineBasedMetrics(object):

interactions, wrapped_results)

-class TimelineBasedMeasurement(page_measurement.PageMeasurement):

+class TimelineBasedMeasurement(page_test.PageTest):

"""Collects multiple metrics pages based on their interaction records.

A timeline measurement shifts the burden of what metrics to collect onto the

@@ -167,7 +167,7 @@ class TimelineBasedMeasurement(page_measurement.PageMeasurement):

tab.browser.StartTracing(category_filter)

- def MeasurePage(self, page, tab, results):

+ def ValidateAndMeasurePage(self, page, tab, results):

""" Collect all possible metrics and added them to results. """

trace_result = tab.browser.StopTracing()

trace_dir = self.options.trace_dir