Issue 449923002: gwt getInnerText -> javascript innerText or textContent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 449923002: gwt getInnerText -> javascript innerText or textContent (Closed)

Created:
6 years, 4 months ago by kuan

Modified:
6 years, 4 months ago

Reviewers:

Base URL:
https://code.google.com/p/dom-distiller/@master

Visibility:
Public.

More Reviews

Description

gwt getInnerText -> javascript innerText or textContent - replace all usage of gwt Element::getInnerText() to javascript innerText or textContent, depending on requirements of each usage. - js innerText doesn't work in gwt, so provide fallback to gwt's impl to cater to gwt tests. in production (i.e. when running in browser), the js innerText will be used, as intended. BUG=396124

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -30 lines)			Patch
M	src/com/dom_distiller/client/ContentExtractor.java	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	src/com/dom_distiller/client/DocumentTitleGetter.java	View	3 chunks	+14 lines, -6 lines	0 comments	Download
M	src/com/dom_distiller/client/DomUtil.java	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/com/dom_distiller/client/IEReadingViewParser.java	View	3 chunks	+20 lines, -6 lines	0 comments	Download
M	src/com/dom_distiller/client/PagingLinksFinder.java	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/com/dom_distiller/client/SchemaOrgParser.java	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	test/com/dom_distiller/client/ContentExtractorTest.java	View	1 chunk	+5 lines, -5 lines	0 comments	Download