Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: src/com/dom_distiller/client/SchemaOrgParser.java

Issue 449923002: gwt getInnerText -> javascript innerText or textContent (Closed) Base URL: https://code.google.com/p/dom-distiller/@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/com/dom_distiller/client/SchemaOrgParser.java
diff --git a/src/com/dom_distiller/client/SchemaOrgParser.java b/src/com/dom_distiller/client/SchemaOrgParser.java
index b006bfc0d51b7efcb8e328ee7d637b85416e98c7..b2619519c7475c6cc93414d804e67916416d6f2e 100644
--- a/src/com/dom_distiller/client/SchemaOrgParser.java
+++ b/src/com/dom_distiller/client/SchemaOrgParser.java
@@ -444,7 +444,8 @@ public class SchemaOrgParser {
if (sTagAttributeMap.containsKey(tagName)) {
value = e.getAttribute(sTagAttributeMap.get(tagName));
}
- if (value.isEmpty()) value = e.getInnerText();
+ // Use javascript textContent (instead of javascript innerText) to include invisible text.
+ if (value.isEmpty()) value = DomUtil.javascriptTextContent(e);
return value;
}
@@ -454,7 +455,9 @@ public class SchemaOrgParser {
String tagName = e.getTagName();
if ((tagName.equalsIgnoreCase("A") || tagName.equalsIgnoreCase("LINK")) &&
e.getAttribute("REL").equalsIgnoreCase(AUTHOR_REL)) {
- author = e.getInnerText();
+ // Use javascript textContent (instead of javascript innerText) to include invisible
+ // text.
+ author = DomUtil.javascriptTextContent(e);
}
return author;
}
« no previous file with comments | « src/com/dom_distiller/client/PagingLinksFinder.java ('k') | test/com/dom_distiller/client/ContentExtractorTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698