Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/com/dom_distiller/client/PagingLinksFinder.java

Issue 449923002: gwt getInnerText -> javascript innerText or textContent (Closed) Base URL: https://code.google.com/p/dom-distiller/@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/com/dom_distiller/client/PagingLinksFinder.java
diff --git a/src/com/dom_distiller/client/PagingLinksFinder.java b/src/com/dom_distiller/client/PagingLinksFinder.java
index ecd0d30342de157b3a86ae71ab7f73d6248edcc8..530786a3161b2773adc3c5b459cf9268c2568d3a 100644
--- a/src/com/dom_distiller/client/PagingLinksFinder.java
+++ b/src/com/dom_distiller/client/PagingLinksFinder.java
@@ -133,7 +133,9 @@ public class PagingLinksFinder {
continue;
}
- String linkText = link.getInnerText();
+ // Use javascript innerText (instead of javascript textContent) to only get visible
+ // text.
+ String linkText = DomUtil.getInnerText(link);
// If the linkText looks like it's not the next or previous page, skip it.
if (StringUtil.match(linkText, EXTRANEOUS_REGEX) || linkText.length() > 25) {
@@ -416,7 +418,9 @@ public class PagingLinksFinder {
for (int i = 0; i < allLinks.getLength(); i++) {
AnchorElement link = AnchorElement.as(allLinks.getItem(i));
- String text = link.getInnerText();
+ // Use javascript innerText (instead of javascript textContent) to get only visible
+ // text.
+ String text = DomUtil.getInnerText(link);
// Trim unnecessary whitespaces from text.
String[] words = StringUtil.split(text, "\\s+");
text = "";
« no previous file with comments | « src/com/dom_distiller/client/IEReadingViewParser.java ('k') | src/com/dom_distiller/client/SchemaOrgParser.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698