Setting the ICU default locale is made explicit. This leads to a few more...

Setting the ICU default locale is made explicit. This leads to a few more
lines of code, but I think it'd be better this way. Setting the ICU
default locale 'quitely' as a part of IsLocaleAvailable is partly responsible for bug 26856. 
With the fix for that bug, Mac Chrome sets the ICU default locale explicitly.
Putting Linux/Windows on the same footing is a "good thing" (TM). 

In addition, I fixed a typo (a spurrious L modifier to a char literal) and
resolved one TODO comment (use uloc_getCharacterOrientation to determine
the text layout direction).

BUG=NONE
TEST=Covered by unittests: L10nUtilTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33646

[TVL, 2009-12-02 01:03:57]

http://codereview.chromium.org/449077/diff/2001/2003
File app/l10n_util_unittest.cc (right):

http://codereview.chromium.org/449077/diff/2001/2003#newcode485
app/l10n_util_unittest.cc:485: // Enable these when we localize to Azerbaijani
is this part still right, the fact that we don't localize to them doesn't
matter, they aren't enabled because it isn't support by our copy of icu?

[jungshik at Google, 2009-12-02 09:00:14]

On 2009/12/02 01:03:57, TVL wrote:
> http://codereview.chromium.org/449077/diff/2001/2003
> File app/l10n_util_unittest.cc (right):
> 
> http://codereview.chromium.org/449077/diff/2001/2003#newcode485
> app/l10n_util_unittest.cc:485: // Enable these when we localize to Azerbaijani
> is this part still right, the fact that we don't localize to them doesn't
> matter, they aren't enabled because it isn't support by our copy of icu?

You're right. Having the ICU data for a language is a necessary condition for
localizing to that language. I'll revise the comment.

[jungshik at Google, 2009-12-02 18:06:10]

Moved SetICUDefaultLocale to GetApplicationLocale()  after calling
CheckAndResolveLocale. That way, Linux/Windows are really on par with Mac OS X.

[TVL, 2009-12-02 18:14:54]

lgtm with 2 nit questions.

http://codereview.chromium.org/449077/diff/10002/6003
File app/l10n_util.cc (right):

http://codereview.chromium.org/449077/diff/10002/6003#newcode511
app/l10n_util.cc:511: // to use with CheckAndResolveLocalto get ICU APIs to work
in that locale.
space before to?

http://codereview.chromium.org/449077/diff/10002/6003#newcode513
app/l10n_util.cc:513: // resources), so mirror the Windows/Linux behavior by
calling
s/by/of/ since windows/linux call it directly now also?