Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2030)

Unified Diff: app/l10n_util_unittest.cc

Issue 449077: Setting the ICU default locale is made explicit. This leads to a few more... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/l10n_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/l10n_util_unittest.cc
===================================================================
--- app/l10n_util_unittest.cc (revision 33451)
+++ app/l10n_util_unittest.cc (working copy)
@@ -477,12 +477,14 @@
EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("he_IL"));
// iw is an obsolete code for Hebrew.
EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("iw"));
+ // Although we're not yet localized to Farsi and Urdu, we
+ // do have the text layout direction information for them.
+ EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("fa"));
+ EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("ur"));
#if 0
- // Enable these when we localize to Farsi, Urdu, Azerbaijani
+ // Enable these when we include the minimal locale data for Azerbaijani
// written in Arabic and Dhivehi. At the moment, our copy of
- // ICU data does not have entry for them.
- EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("fa"));
- EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("ur"));
+ // ICU data does not have entries for them.
EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("az_Arab"));
// Dhivehi that uses Thaana script.
EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("dv"));
« no previous file with comments | « app/l10n_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698