Setting the ICU default locale is made explicit. This leads to a few more...

app/l10n_util_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(OS_LINUX)
 #include <cstdlib>
 #endif
 
@@ skipping 459 matching lines @@
   }
 }
 
 TEST_F(L10nUtilTest, GetTextDirection) {
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("ar"));
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("ar_EG"));
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("he"));
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("he_IL"));
   // iw is an obsolete code for Hebrew.
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("iw"));
-#if 0
-  // Enable these when we localize to Farsi, Urdu, Azerbaijani
-  // written in Arabic and Dhivehi. At the moment, our copy of
-  // ICU data does not have entry for them.
+  // Although we're not yet localized to Farsi and Urdu, we
+  // do have the text layout direction information for them.
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("fa"));
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("ur"));
+#if 0
+  // Enable these when we include the minimal locale data for Azerbaijani
+  // written in Arabic and Dhivehi. At the moment, our copy of
+  // ICU data does not have entries for them.
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("az_Arab"));
   // Dhivehi that uses Thaana script.
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("dv"));
 #endif
   EXPECT_EQ(l10n_util::LEFT_TO_RIGHT, GetTextDirection("en"));
   // Chinese in China with '-'.
   EXPECT_EQ(l10n_util::LEFT_TO_RIGHT, GetTextDirection("zh-CN"));
   // Filipino : 3-letter code
   EXPECT_EQ(l10n_util::LEFT_TO_RIGHT, GetTextDirection("fil"));
   // Russian
   EXPECT_EQ(l10n_util::LEFT_TO_RIGHT, GetTextDirection("ru"));
   // Japanese that uses multiple scripts
   EXPECT_EQ(l10n_util::LEFT_TO_RIGHT, GetTextDirection("ja"));
 }
 
 // Test upper and lower case string conversion.
 TEST_F(L10nUtilTest, UpperLower) {
   string16 mixed(ASCIIToUTF16("Text with UPPer & lowER casE."));
   const string16 expected_lower(ASCIIToUTF16("text with upper & lower case."));
   const string16 expected_upper(ASCIIToUTF16("TEXT WITH UPPER & LOWER CASE."));
 
   string16 result = l10n_util::ToLower(mixed);
   EXPECT_EQ(result, expected_lower);
 
   result = l10n_util::ToUpper(mixed);
   EXPECT_EQ(result, expected_upper);
 }