Issue 448343002: Makes filter step continue on if error

Issue 448343002: Makes filter step continue on if error (Closed)

Created:
6 years, 4 months ago by sky

Modified:
6 years, 4 months ago

Reviewers:
iannucci

CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Project:
tools

Visibility:
Public.

More Reviews

Description

Makes filter step continue on if error Errors shouldn't block, we can continue on and compile. Most likely an error in the filter step indicates a problem with gyp that'll fail later on. Better to continue though so that folks don't blame the analyze step. BUG=109173 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288364

Patch Set 1 #

Patch Set 2 : --no-find-copies #

Total comments: 1

Patch Set 3 : add hello step #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -8 lines)			Patch
M	scripts/slave/recipe_modules/filter/api.py	View		1 chunk	+17 lines, -8 lines	0 comments	Download
M	scripts/slave/recipe_modules/filter/example.py	View	1 2	3 chunks	+11 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_exes.json	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/filter/example.expected/analyzes_returns_true.json	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
A	scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json	View	1 2	1 chunk	+43 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/filter/example.expected/basic.json	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/filter/example.expected/doesnt_match_exclusion.json	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/filter/example.expected/match_exclusion.json	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

iannucci

lgtm https://codereview.chromium.org/448343002/diff/20001/scripts/slave/recipe_modules/filter/example.py File scripts/slave/recipe_modules/filter/example.py (right): https://codereview.chromium.org/448343002/diff/20001/scripts/slave/recipe_modules/filter/example.py#newcode22 scripts/slave/recipe_modules/filter/example.py:22: api.filter.matching_exes) could we add a bogus step afterwards ...

6 years, 4 months ago (2014-08-07 23:43:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/448343002/40001

6 years, 4 months ago (2014-08-08 15:39:15 UTC) #6

Message was sent while issue was closed.

Change committed as 288364

Expand Messages | Collapse Messages