Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json

Issue 448343002: Makes filter step continue on if error (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: add hello step Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json
diff --git a/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json b/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json
new file mode 100644
index 0000000000000000000000000000000000000000..2016518f9db1eb76a511640a08b55d58d3c6b1f8
--- /dev/null
+++ b/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json
@@ -0,0 +1,43 @@
+[
+ {
+ "cmd": [
+ "git",
+ "diff",
+ "--cached",
+ "--name-only"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "git diff to analyze patch",
+ "stdout": "/path/to/tmp/"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "[SLAVE_BUILD]/build/gyp_chromium",
+ "--analyzer2",
+ "{\"files\": [\"foo.cc\"], \"targets\": null}",
+ "/path/to/tmp/json"
+ ],
+ "env": {
+ "GYP_DEFINES": "component=static_library gomadir='[BUILD]/goma' target_arch=x64 use_goma=1"
+ },
+ "name": "analyze",
+ "~followup_annotations": [
+ "step returned non-zero exit code: -1",
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"status\": \"No dependency\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"targets\": []@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@",
+ "@@@STEP_WARNINGS@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "echo",
+ "Why hello, there."
+ ],
+ "name": "hello"
+ }
+]

Powered by Google App Engine
This is Rietveld 408576698