Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: scripts/slave/recipe_modules/filter/example.py

Issue 448343002: Makes filter step continue on if error (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: add hello step Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/filter/example.py
diff --git a/scripts/slave/recipe_modules/filter/example.py b/scripts/slave/recipe_modules/filter/example.py
index c1388a98c32a06ed6b91e649c030f861420b78d1..d2bb3e3e382015c19f279d071b6ee9eeb8486c83 100644
--- a/scripts/slave/recipe_modules/filter/example.py
+++ b/scripts/slave/recipe_modules/filter/example.py
@@ -9,6 +9,7 @@ DEPS = [
'path',
'properties',
'raw_io',
+ 'step',
]
def GenSteps(api):
@@ -20,6 +21,7 @@ def GenSteps(api):
assert (not api.properties['example_matching_exes'] or
list(api.properties['example_matching_exes']) ==
api.filter.matching_exes)
+ api.step('hello', ['echo', 'Why hello, there.'])
def GenTests(api):
# Trivial test with no exclusions and nothing matching.
@@ -76,3 +78,12 @@ def GenTests(api):
api.override_step_data(
'analyze',
api.json.output({'error': 'ERROR'})))
+
+ # Analyze with python returning bad status.
+ yield (api.test('bad_retcode_doesnt_fail') +
+ api.properties(matching_exes=None) +
+ api.properties(example_matching_exes=None) +
+ api.properties(example_result=1) +
+ api.step_data(
+ 'analyze',
+ retcode=-1))
« no previous file with comments | « scripts/slave/recipe_modules/filter/api.py ('k') | scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698