Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Issue 448043003: Drop const_iterator for AttributeCollection (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
esprehn, adamk
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Drop const_iterator for AttributeCollection Drop const_iterator for AttributeCollection and use iterator instead as it is equivalent. AttributeCollection::iterator is inherently const, while MutableAttributeCollection::iterator isn't. Since here the constness is defined by the collection type (AttributeCollection vs MutableAttributeCollection), I don't think we need to distinguish iterator vs const_iterator. Using iterator everywhere also makes the code a bit shorter. R=adamk@chromium.org, esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -60 lines) Patch
M Source/core/css/SelectorChecker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/AttributeCollection.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/DatasetDOMStringMap.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/ElementData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/PresentationAttributeStyle.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/markup.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathNodeSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathStep.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 4 months ago (2014-08-07 20:30:49 UTC) #1
adamk
rslgtm Given how little iterator usage there is in Blink, opting for shorter code sounds ...
6 years, 4 months ago (2014-08-07 20:32:00 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-07 20:55:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/448043003/1
6 years, 4 months ago (2014-08-07 20:58:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-07 21:51:15 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 22:20:55 UTC) #6
Message was sent while issue was closed.
Change committed as 179760

Powered by Google App Engine
This is Rietveld 408576698