Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: Source/core/css/SelectorChecker.cpp

Issue 448043003: Drop const_iterator for AttributeCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/SelectorChecker.h ('k') | Source/core/dom/AttributeCollection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 ASSERT(selectorAttr.localName() != starAtom); // Should not be possible from the CSS grammar. 460 ASSERT(selectorAttr.localName() != starAtom); // Should not be possible from the CSS grammar.
461 461
462 // Synchronize the attribute in case it is lazy-computed. 462 // Synchronize the attribute in case it is lazy-computed.
463 // Currently all lazy properties have a null namespace, so only pass localNa me(). 463 // Currently all lazy properties have a null namespace, so only pass localNa me().
464 element.synchronizeAttribute(selectorAttr.localName()); 464 element.synchronizeAttribute(selectorAttr.localName());
465 465
466 const AtomicString& selectorValue = selector.value(); 466 const AtomicString& selectorValue = selector.value();
467 bool caseInsensitive = selector.attributeMatchType() == CSSSelector::CaseIns ensitive; 467 bool caseInsensitive = selector.attributeMatchType() == CSSSelector::CaseIns ensitive;
468 468
469 AttributeCollection attributes = element.attributesWithoutUpdate(); 469 AttributeCollection attributes = element.attributesWithoutUpdate();
470 AttributeCollection::const_iterator end = attributes.end(); 470 AttributeCollection::iterator end = attributes.end();
471 for (AttributeCollection::const_iterator it = attributes.begin(); it != end; ++it) { 471 for (AttributeCollection::iterator it = attributes.begin(); it != end; ++it) {
472 const Attribute& attributeItem = *it; 472 const Attribute& attributeItem = *it;
473 473
474 if (!attributeItem.matches(selectorAttr)) 474 if (!attributeItem.matches(selectorAttr))
475 continue; 475 continue;
476 476
477 if (attributeValueMatches(attributeItem, match, selectorValue, !caseInse nsitive)) 477 if (attributeValueMatches(attributeItem, match, selectorValue, !caseInse nsitive))
478 return true; 478 return true;
479 479
480 if (caseInsensitive) 480 if (caseInsensitive)
481 continue; 481 continue;
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 return isHTMLOptionElement(element) && toHTMLOptionElement(element).spatialN avigationFocused() && isFrameFocused(element); 1129 return isHTMLOptionElement(element) && toHTMLOptionElement(element).spatialN avigationFocused() && isFrameFocused(element);
1130 } 1130 }
1131 1131
1132 template 1132 template
1133 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const; 1133 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const;
1134 1134
1135 template 1135 template
1136 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const; 1136 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const;
1137 1137
1138 } 1138 }
OLDNEW
« no previous file with comments | « Source/core/css/SelectorChecker.h ('k') | Source/core/dom/AttributeCollection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698