Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: Source/core/dom/ElementData.cpp

Issue 448043003: Drop const_iterator for AttributeCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 bool ElementData::isEquivalent(const ElementData* other) const 107 bool ElementData::isEquivalent(const ElementData* other) const
108 { 108 {
109 AttributeCollection attributes = this->attributes(); 109 AttributeCollection attributes = this->attributes();
110 if (!other) 110 if (!other)
111 return attributes.isEmpty(); 111 return attributes.isEmpty();
112 112
113 AttributeCollection otherAttributes = other->attributes(); 113 AttributeCollection otherAttributes = other->attributes();
114 if (attributes.size() != otherAttributes.size()) 114 if (attributes.size() != otherAttributes.size())
115 return false; 115 return false;
116 116
117 AttributeCollection::const_iterator end = attributes.end(); 117 AttributeCollection::iterator end = attributes.end();
118 for (AttributeCollection::const_iterator it = attributes.begin(); it != end; ++it) { 118 for (AttributeCollection::iterator it = attributes.begin(); it != end; ++it) {
119 const Attribute* otherAttr = otherAttributes.find(it->name()); 119 const Attribute* otherAttr = otherAttributes.find(it->name());
120 if (!otherAttr || it->value() != otherAttr->value()) 120 if (!otherAttr || it->value() != otherAttr->value())
121 return false; 121 return false;
122 } 122 }
123 return true; 123 return true;
124 } 124 }
125 125
126 void ElementData::trace(Visitor* visitor) 126 void ElementData::trace(Visitor* visitor)
127 { 127 {
128 if (m_isUnique) 128 if (m_isUnique)
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 return adoptRefWillBeNoop(new (slot) ShareableElementData(*this)); 212 return adoptRefWillBeNoop(new (slot) ShareableElementData(*this));
213 } 213 }
214 214
215 void UniqueElementData::traceAfterDispatch(Visitor* visitor) 215 void UniqueElementData::traceAfterDispatch(Visitor* visitor)
216 { 216 {
217 visitor->trace(m_presentationAttributeStyle); 217 visitor->trace(m_presentationAttributeStyle);
218 ElementData::traceAfterDispatch(visitor); 218 ElementData::traceAfterDispatch(visitor);
219 } 219 }
220 220
221 } // namespace blink 221 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698