Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 447493002: [Android] Force showing insertion handle when paste popup activated (Closed)

Created:
6 years, 4 months ago by jdduke (slow)
Modified:
6 years, 4 months ago
CC:
AKVT, chromium-reviews, darin-cc_chromium.org, jam, miu+watch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, raghu, Cyan, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Force showing insertion handle when paste popup activated An unhandled context menu may result in the showing of the paste popup. However, this paste popup notification is not well-ordered with respect to other notifications that determine insertion handle state, namely, position and region editability updates. Consequently, the paste popup may be shown without a corresponding insertion handle. Resolve this by forcing an editability and position update when the paste popup notification is received. BUG=400304, 400330, 396997 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287845

Patch Set 1 #

Patch Set 2 : Fix for emptiness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jdduke (slow)
aelias@: PTAL. This is a rather unfortunate workaround. My plan is to remove the extra ...
6 years, 4 months ago (2014-08-05 16:28:41 UTC) #1
aelias_OOO_until_Jul13
lgtm. But it would be nice to get to the bottom of the raciness here ...
6 years, 4 months ago (2014-08-05 20:42:02 UTC) #2
jdduke (slow)
On 2014/08/05 20:42:02, aelias wrote: > lgtm. But it would be nice to get to ...
6 years, 4 months ago (2014-08-05 21:00:40 UTC) #3
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 4 months ago (2014-08-05 21:00:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/447493002/1
6 years, 4 months ago (2014-08-05 21:03:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 01:23:40 UTC) #6
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 4 months ago (2014-08-06 03:29:33 UTC) #7
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 4 months ago (2014-08-06 15:13:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/447493002/20001
6 years, 4 months ago (2014-08-06 15:14:52 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 20:35:08 UTC) #10
Message was sent while issue was closed.
Change committed as 287845

Powered by Google App Engine
This is Rietveld 408576698