content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 447493002: [Android] Force showing insertion handle when paste popup activated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 447493002: [Android] Force showing insertion handle when paste popup activated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for emptiness Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 9733a58784af0c70ff24a72caa08e94a4c75e899..21a5cbc57311a29037372d116c34bc1416047999 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2467,6 +2467,7 @@ public class ContentViewCore

@SuppressWarnings("unused")

@CalledByNative

private void showPastePopup(int xDip, int yDip) {

+ if (!mHasInsertion) return;

final float contentOffsetYPix = mRenderCoordinates.getContentOffsetYPix();

getPastePopup().showAt(

(int) mRenderCoordinates.fromDipToPix(xDip),

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | no next file » | no next file with comments »