Issue 445933005: Support multiple STUN servers for PeerConnection.

Issue 445933005: Support multiple STUN servers for PeerConnection. (Closed)

Created:
6 years, 4 months ago by jiayl

Modified:
6 years, 4 months ago

Reviewers:
Sergey Ulanov, Mallinath (Gone from Chromium)

CC:
chromium-reviews, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Support multiple STUN servers for PeerConnection. BUG=https://code.google.com/p/webrtc/issues/detail?id=3310 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288535

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -15 lines)			Patch
M	content/renderer/media/webrtc/peer_connection_dependency_factory.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	content/renderer/p2p/port_allocator.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/renderer/p2p/port_allocator.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

lgtm https://codereview.chromium.org/445933005/diff/1/remoting/client/plugin/pepper_port_allocator.cc File remoting/client/plugin/pepper_port_allocator.cc (right): https://codereview.chromium.org/445933005/diff/1/remoting/client/plugin/pepper_port_allocator.cc#newcode106 remoting/client/plugin/pepper_port_allocator.cc:106: if (!config->stun_servers.empty() && FYI: there is https://codereview.chromium.org/452923005/ that ...

6 years, 4 months ago (2014-08-08 19:57:16 UTC) #3

Sergey Ulanov

Also see https://codereview.chromium.org/456013002 - you can revert src/remoting changes in this CL

6 years, 4 months ago (2014-08-08 22:13:02 UTC) #4

jiayl

On 2014/08/08 22:13:02, Sergey Ulanov wrote: > Also see https://codereview.chromium.org/456013002 - you can revert src/remoting ...

6 years, 4 months ago (2014-08-08 23:18:53 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/445933005/20001

6 years, 4 months ago (2014-08-08 23:21:57 UTC) #7

Message was sent while issue was closed.

Change committed as 288535

Expand Messages | Collapse Messages