Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 456013002: Use all stun addresses in PepperPortAllocator. (Closed)

Created:
6 years, 4 months ago by Sergey Ulanov
Modified:
6 years, 4 months ago
Reviewers:
jiayl, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use all stun addresses in PepperPortAllocator. Previously PepperPortAllocator was using only the first STUN server because cricket::PortConfiguration didn't support more than one STUN server. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M remoting/client/plugin/pepper_port_allocator.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
This applies on top of https://codereview.chromium.org/452923005/
6 years, 4 months ago (2014-08-08 22:11:47 UTC) #1
dcaiafa
lgtm
6 years, 4 months ago (2014-08-11 18:16:15 UTC) #2
jiayl
lgtm
6 years, 4 months ago (2014-08-11 18:30:24 UTC) #3
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-12 16:49:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/456013002/1
6 years, 4 months ago (2014-08-12 16:53:30 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 01:19:06 UTC) #6
Message was sent while issue was closed.
Change committed as 289143

Powered by Google App Engine
This is Rietveld 408576698