Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 452923005: Add PepperAddressResolver. (Closed)

Created:
6 years, 4 months ago by Sergey Ulanov
Modified:
6 years, 4 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add PepperAddressResolver. The new PepperAddressResolver provides AsyncResolverInterface implementation to P2PTransportChannel and is used there to resolve address of the STUN server. It's required after recent changes in libjingle. Also remove STUN address resolution from PepperPortAllocator as it is not needed there anymore. BUG=401102 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288549

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -88 lines) Patch
A remoting/client/plugin/pepper_address_resolver.h View 1 chunk +45 lines, -0 lines 0 comments Download
A remoting/client/plugin/pepper_address_resolver.cc View 1 2 1 chunk +84 lines, -0 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_port_allocator.cc View 5 chunks +3 lines, -86 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sergey Ulanov
6 years, 4 months ago (2014-08-08 19:26:30 UTC) #1
dcaiafa
lgtm https://codereview.chromium.org/452923005/diff/20001/remoting/client/plugin/pepper_address_resolver.cc File remoting/client/plugin/pepper_address_resolver.cc (right): https://codereview.chromium.org/452923005/diff/20001/remoting/client/plugin/pepper_address_resolver.cc#newcode59 remoting/client/plugin/pepper_address_resolver.cc:59: delete this; I assume that pp::CompletionCallbackFactory handles the ...
6 years, 4 months ago (2014-08-08 19:45:21 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/452923005/diff/20001/remoting/client/plugin/pepper_address_resolver.cc File remoting/client/plugin/pepper_address_resolver.cc (right): https://codereview.chromium.org/452923005/diff/20001/remoting/client/plugin/pepper_address_resolver.cc#newcode59 remoting/client/plugin/pepper_address_resolver.cc:59: delete this; On 2014/08/08 19:45:20, dcaiafa wrote: > I ...
6 years, 4 months ago (2014-08-08 19:49:09 UTC) #3
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-08 19:49:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/452923005/20001
6 years, 4 months ago (2014-08-08 19:50:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-09 00:33:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-09 00:40:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/4373) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/1424)
6 years, 4 months ago (2014-08-09 00:40:48 UTC) #8
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-09 01:07:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/452923005/40001
6 years, 4 months ago (2014-08-09 01:11:45 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 10:20:37 UTC) #11
Message was sent while issue was closed.
Change committed as 288549

Powered by Google App Engine
This is Rietveld 408576698