Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: Source/modules/webaudio/AudioSummingJunction.h

Issue 445453006: Add comments to vectors/hash sets of raw pointers to on-heap objects used in webaudio/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/AudioSummingJunction.h
diff --git a/Source/modules/webaudio/AudioSummingJunction.h b/Source/modules/webaudio/AudioSummingJunction.h
index b6a25be10629c5469437e4865e63792d98fa4d5b..041bb108438f4fa30d854c44fc7db0582f640796 100644
--- a/Source/modules/webaudio/AudioSummingJunction.h
+++ b/Source/modules/webaudio/AudioSummingJunction.h
@@ -67,12 +67,16 @@ protected:
// m_outputs contains the AudioNodeOutputs representing current connections which are not disabled.
// The rendering code should never use this directly, but instead uses m_renderingOutputs.
+ // Oilpan: Since items are added to the hash set by the audio thread (not registered to Oilpan),
+ // we cannot use a HeapHashSet.
HashSet<AudioNodeOutput*> m_outputs;
// m_renderingOutputs is a copy of m_outputs which will never be modified during the graph rendering on the audio thread.
// This is the list which is used by the rendering code.
// Whenever m_outputs is modified, the context is told so it can later update m_renderingOutputs from m_outputs at a safe time.
// Most of the time, m_renderingOutputs is identical to m_outputs.
+ // Oilpan: Since items are added to the vector by the audio thread (not registered to Oilpan),
+ // we cannot use a HeapHashSet.
zerny-chromium 2014/08/05 13:21:09 s/HeapHashSet/HeapVector
haraken 2014/08/05 13:34:18 Done.
Vector<AudioNodeOutput*> m_renderingOutputs;
// m_renderingStateNeedUpdating keeps track if m_outputs is modified.
« Source/modules/webaudio/AudioContext.h ('K') | « Source/modules/webaudio/AudioNodeInput.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698