Add comments to vectors/hash sets of raw pointers to on-heap objects used in webaudio/

Add comments to vectors/hash sets of raw pointers to on-heap objects used in webaudio/

webaudio/ sometimes has to use vectors/hash sets of raw pointers to on-heap objects,
if items are added to those vectors/hash sets by the audio thread. This is because
the audio thread is not registered to Oilpan and thus the audio thread is not allowed
to expand entries of the vectors/hash sets.

This CL adds comments to those vectors/hash sets about why they use off-heap
vectors/hash sets of raw pointers.

BUG=340522
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179552

[haraken, 2014-08-05 13:12:18]

PTAL

[zerny-chromium, 2014-08-05 13:21:09]

lgtm

https://codereview.chromium.org/445453006/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioContext.h (right):

https://codereview.chromium.org/445453006/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioContext.h:362: // we cannot use a
HeapVector/HeapHashSet.
just HeapVector here

https://codereview.chromium.org/445453006/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioSummingJunction.h (right):

https://codereview.chromium.org/445453006/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioSummingJunction.h:79: // we cannot use a
HeapHashSet.
s/HeapHashSet/HeapVector

[haraken, 2014-08-05 13:34:19]

Thanks for review!

https://codereview.chromium.org/445453006/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioContext.h (right):

https://codereview.chromium.org/445453006/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioContext.h:362: // we cannot use a
HeapVector/HeapHashSet.
On 2014/08/05 13:21:09, zerny-chromium wrote:
> just HeapVector here

Done.

https://codereview.chromium.org/445453006/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioSummingJunction.h (right):

https://codereview.chromium.org/445453006/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioSummingJunction.h:79: // we cannot use a
HeapHashSet.
On 2014/08/05 13:21:09, zerny-chromium wrote:
> s/HeapHashSet/HeapVector

Done.

[haraken, 2014-08-05 13:34:21]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-05 13:35:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/445453006/20001

[commit-bot: I haz the power, 2014-08-05 18:21:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21000)

[commit-bot: I haz the power, 2014-08-05 20:57:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 20:57:03]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21071)

[haraken, 2014-08-05 23:16:44]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-05 23:19:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/445453006/20001

[haraken, 2014-08-06 00:44:15]

The CQ bit was unchecked by haraken@chromium.org

[haraken, 2014-08-06 00:44:19]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-06 00:48:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/445453006/20001

[commit-bot: I haz the power, 2014-08-06 00:51:09]

Change committed as 179552