Source/modules/webaudio/AudioNodeInput.h - Issue 445453006: Add comments to vectors/hash sets of raw pointers to on-heap objects used in webaudio/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioNodeInput.h

Issue 445453006: Add comments to vectors/hash sets of raw pointers to on-heap objects used in webaudio/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webaudio/AudioContext.h ('K') | « Source/modules/webaudio/AudioContext.h ('k') | Source/modules/webaudio/AudioSummingJunction.h » ('j') | Source/modules/webaudio/AudioSummingJunction.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioNodeInput.h

diff --git a/Source/modules/webaudio/AudioNodeInput.h b/Source/modules/webaudio/AudioNodeInput.h

index e5298b3657bfa5d69b096253b1e611c68dea2fd7..294f170fbd15947c98888b1dd8e5238a001167c7 100644

--- a/Source/modules/webaudio/AudioNodeInput.h

+++ b/Source/modules/webaudio/AudioNodeInput.h

@@ -87,6 +87,8 @@ private:

// m_disabledOutputs contains the AudioNodeOutputs which are disabled (will not be processed) by the audio graph rendering.

// But, from JavaScript's perspective, these outputs are still connected to us.

// Generally, these represent disabled connections from "notes" which have finished playing but are not yet garbage collected.

+ // Oilpan: Since items are added to the hash set by the audio thread (not registered to Oilpan),

+ // we cannot use a HeapHashSet.

HashSet<AudioNodeOutput*> m_disabledOutputs;

// Called from context's audio thread.