Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 444753002: Allow the browser to choose PasswordManager's authorization prompt policy. (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow the browser to choose PasswordManager's authorization prompt policy. This only affects OSX. Recently, Chrome stopped prompting users for access to the keychain to autofill passwords (to pull in passwords from other browsers). Opera wants to use a different policy, so pull the logic into password_manager_client. BUG=178358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M components/password_manager/core/browser/password_manager.cc View 1 chunk +1 line, -11 lines 0 comments Download
M components/password_manager/core/browser/password_manager_client.h View 2 chunks +6 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager_client.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
erikchen
isherman: Please review.
6 years, 4 months ago (2014-08-05 19:27:23 UTC) #1
Ilya Sherman
LGTM
6 years, 4 months ago (2014-08-05 20:17:53 UTC) #2
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 4 months ago (2014-08-05 20:49:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/444753002/1
6 years, 4 months ago (2014-08-05 20:54:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 00:57:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 04:13:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/3601)
6 years, 4 months ago (2014-08-06 04:13:42 UTC) #7
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 4 months ago (2014-08-06 17:34:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/444753002/1
6 years, 4 months ago (2014-08-06 17:34:56 UTC) #9
commit-bot: I haz the power
Change committed as 287825
6 years, 4 months ago (2014-08-06 19:24:21 UTC) #10
Jiang Jiang
6 years, 4 months ago (2014-08-06 19:34:03 UTC) #11
Message was sent while issue was closed.
Thanks!

I was going to submit a patch for that as per our discussion, but didn't get
started yet.

Powered by Google App Engine
This is Rietveld 408576698