Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 444753002: Allow the browser to choose PasswordManager's authorization prompt policy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index a3f6f5c9cc198f18c6a543c1882d73473d39fafe..cf6ef7dab13cec0dd7f3bd050503b4f6f8953df5 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -373,18 +373,8 @@ void PasswordManager::CreatePendingLoginManagers(
new PasswordFormManager(this, client_, driver_, *iter, ssl_valid);
pending_login_managers_.push_back(manager);
- // Password Autofill is supposed to be a convenience. If it creates a
- // blocking dialog, it is no longer convenient. We should only prompt the
- // user after a full username has been typed in. Until that behavior is
- // implemented, never prompt the user for keychain access.
- // Effectively, this means that passwords stored by Chrome still work,
- // since Chrome can access those without a prompt, but passwords stored by
- // Safari, Firefox, or Chrome Canary will not work. Note that the latest
- // build of Safari and Firefox don't create keychain items with the
- // relevant tags anyways (7/11/2014).
- // http://crbug.com/178358
PasswordStore::AuthorizationPromptPolicy prompt_policy =
- PasswordStore::DISALLOW_PROMPT;
+ client_->GetAuthorizationPromptPolicy(*iter);
manager->FetchMatchingLoginsFromPasswordStore(prompt_policy);
}
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698