Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 444753002: Allow the browser to choose PasswordManager's authorization prompt policy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_manager_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager_client.cc
diff --git a/components/password_manager/core/browser/password_manager_client.cc b/components/password_manager/core/browser/password_manager_client.cc
index fe5a7de70360868df303a9d6edb1acf2caf0fc87..9b0bba3cc4889a855b7a777cee0bd73a4afe0218 100644
--- a/components/password_manager/core/browser/password_manager_client.cc
+++ b/components/password_manager/core/browser/password_manager_client.cc
@@ -33,4 +33,20 @@ bool PasswordManagerClient::IsLoggingActive() const {
return false;
}
+PasswordStore::AuthorizationPromptPolicy
+PasswordManagerClient::GetAuthorizationPromptPolicy(
+ const autofill::PasswordForm& form) {
+ // Password Autofill is supposed to be a convenience. If it creates a
+ // blocking dialog, it is no longer convenient. We should only prompt the
+ // user after a full username has been typed in. Until that behavior is
+ // implemented, never prompt the user for keychain access.
+ // Effectively, this means that passwords stored by Chrome still work,
+ // since Chrome can access those without a prompt, but passwords stored by
+ // Safari, Firefox, or Chrome Canary will not work. Note that the latest
+ // build of Safari and Firefox don't create keychain items with the
+ // relevant tags anyways (7/11/2014).
+ // http://crbug.com/178358
+ return PasswordStore::DISALLOW_PROMPT;
+}
+
} // namespace password_manager
« no previous file with comments | « components/password_manager/core/browser/password_manager_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698