chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 444603003: Hook up the Mac password bubble to the browser and add browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 444603003: Hook up the Mac password bubble to the browser and add browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sort gypi Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index df029aee357b8dec1ca6818c1e06058f092054f7..876185474853d41398b9a3015cefb2d70bd0b743 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -354,7 +354,7 @@ void ChromePasswordManagerClient::CommitFillPasswordForm(

}

bool ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled() {

-#if !defined(USE_AURA)

+#if !defined(USE_AURA) && !defined(OS_MACOSX)

vabr (Chromium) 2014/08/05 13:14:26 This is within //chrome, which means desktop only.

dconnelly 2014/08/06 12:46:12 Done.

return false;

#endif

CommandLine* command_line = CommandLine::ForCurrentProcess();