Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 444603003: Hook up the Mac password bubble to the browser and add browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sort gypi Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 5 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
6 6
7 #include "base/bind_helpers.h" 7 #include "base/bind_helpers.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 web_contents()->GetRenderViewHost()->GetRoutingID(), 347 web_contents()->GetRenderViewHost()->GetRoutingID(),
348 can_use_log_router_)); 348 can_use_log_router_));
349 } 349 }
350 350
351 void ChromePasswordManagerClient::CommitFillPasswordForm( 351 void ChromePasswordManagerClient::CommitFillPasswordForm(
352 autofill::PasswordFormFillData* data) { 352 autofill::PasswordFormFillData* data) {
353 driver_.FillPasswordForm(*data); 353 driver_.FillPasswordForm(*data);
354 } 354 }
355 355
356 bool ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled() { 356 bool ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled() {
357 #if !defined(USE_AURA) 357 #if !defined(USE_AURA) && !defined(OS_MACOSX)
vabr (Chromium) 2014/08/05 13:14:26 This is within //chrome, which means desktop only.
dconnelly 2014/08/06 12:46:12 Done.
358 return false; 358 return false;
359 #endif 359 #endif
360 CommandLine* command_line = CommandLine::ForCurrentProcess(); 360 CommandLine* command_line = CommandLine::ForCurrentProcess();
361 if (command_line->HasSwitch(switches::kDisableSavePasswordBubble)) 361 if (command_line->HasSwitch(switches::kDisableSavePasswordBubble))
362 return false; 362 return false;
363 363
364 if (command_line->HasSwitch(switches::kEnableSavePasswordBubble)) 364 if (command_line->HasSwitch(switches::kEnableSavePasswordBubble))
365 return true; 365 return true;
366 366
367 std::string group_name = 367 std::string group_name =
(...skipping 11 matching lines...) Expand all
379 379
380 if (command_line->HasSwitch( 380 if (command_line->HasSwitch(
381 password_manager::switches::kEnableManagerForSyncSignin)) 381 password_manager::switches::kEnableManagerForSyncSignin))
382 return true; 382 return true;
383 383
384 // Default is enabled. 384 // Default is enabled.
385 std::string group_name = 385 std::string group_name =
386 base::FieldTrialList::FindFullName("PasswordManagerStateForSyncSignin"); 386 base::FieldTrialList::FindFullName("PasswordManagerStateForSyncSignin");
387 return group_name != "Disabled"; 387 return group_name != "Disabled";
388 } 388 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698