Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 444603003: Hook up the Mac password bubble to the browser and add browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sort gypi Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/password_manager/chrome_password_manager_client.cc ('K') | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/ui/browser_dialogs.h » ('j') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_browsertest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index 788e76ce5225aa0b9eeaf9c42b343ea0a71ccc0b..6da9725794228a429223219b35315fc9d6d92049 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -788,15 +788,12 @@ void Translate(Browser* browser) {
}
void ManagePasswordsForPage(Browser* browser) {
-// TODO(mkwst): Implement this feature on Mac: http://crbug.com/261628
-#if !defined(OS_MACOSX)
if (!browser->window()->IsActive())
return;
WebContents* web_contents =
browser->tab_strip_model()->GetActiveWebContents();
chrome::ShowManagePasswordsBubble(web_contents);
-#endif
}
void TogglePagePinnedToStartScreen(Browser* browser) {
« chrome/browser/password_manager/chrome_password_manager_client.cc ('K') | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/ui/browser_dialogs.h » ('j') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_browsertest.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698