Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 444123003: Revert 284806 "Disable two recent Channel ID-related CLs to inve..." (Closed)

Created:
6 years, 4 months ago by wtc
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284806 "Disable two recent Channel ID-related CLs to inve..." The cause of the secure QUIC performance degradation has been identified and fixed in r286400. > Disable two recent Channel ID-related CLs to investigate a secure QUIC performance degradation. > > The change to quic_stream_factory.cc disables > https://codereview.chromium.org/346323002/ > > The change to quic_crypto_client_stream.cc disables > https://codereview.chromium.org/355293003/ > > R=rch@chromium.org > BUG=396185 > > Review URL: https://codereview.chromium.org/414523004 R=rch@chromium.org BUG=396185 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M trunk/src/net/quic/quic_crypto_client_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/net/quic/quic_stream_factory.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wtc
6 years, 4 months ago (2014-08-06 21:10:45 UTC) #1
wtc
6 years, 4 months ago (2014-08-06 21:15:24 UTC) #2
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-08-06 21:16:27 UTC) #3
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 4 months ago (2014-08-06 21:20:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 21:21:23 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 4 months ago (2014-08-06 21:21:23 UTC) #6
wtc
6 years, 4 months ago (2014-08-06 21:28:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r287860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698