Issue 414523004: Disable two recent Channel ID-related CLs to investigate a secure QUIC performance degradation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 414523004: Disable two recent Channel ID-related CLs to investigate a secure QUIC performance degradation. (Closed)

Created:
6 years, 5 months ago by wtc

Modified:
6 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable two recent Channel ID-related CLs to investigate a secure QUIC performance degradation. The change to quic_stream_factory.cc disables https://codereview.chromium.org/346323002/ The change to quic_crypto_client_stream.cc disables https://codereview.chromium.org/355293003/ R=rch@chromium.org BUG=396185 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284806

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	net/quic/quic_crypto_client_stream.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	net/quic/quic_stream_factory.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/414523004/1

6 years, 5 months ago (2014-07-22 20:09:49 UTC) #3

wtc

Committed patchset #1 manually as r284806 (presubmit successful).

6 years, 5 months ago (2014-07-22 23:38:04 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-22 23:39:13 UTC) #5

Message was sent while issue was closed.

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

Expand Messages | Collapse Messages