v8::TryCatch should cancel the scheduled exception on Reset.

v8::TryCatch should cancel the scheduled exception on Reset.

v8::TryCatch cancels the scheduled exception on destruction if |Rethrow|
was never called.
It is reasonable to do the same in |Reset|.

BUG=362388, 359386
LOG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22963

[haraken, 2014-08-06 05:54:08]

This looks nice and simplifies the TryCatch logic in the binding layer (c.f.,
binding side CL is this one: https://codereview.chromium.org/232563003/).

[aandrey, 2014-08-06 06:31:09]

https://codereview.chromium.org/443853002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/443853002/diff/1/include/v8.h#newcode5124
include/v8.h:5124: void Reset();
should we also update the docs for Reset() ?

[yhirano, 2014-08-06 09:00:04]

https://codereview.chromium.org/443853002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/443853002/diff/1/include/v8.h#newcode5124
include/v8.h:5124: void Reset();
On 2014/08/06 06:31:08, aandrey wrote:
> should we also update the docs for Reset() ?

Done.

[yhirano, 2014-08-07 01:18:41]

Correct reviewer (mstarzinger => mstarzinger@chromium.org)

[yhirano, 2014-08-07 01:19:33]

Correct reviewer (chromium.com => chromium.org)

[Michael Starzinger, 2014-08-07 08:40:36]

LGTM. I'll land this for you.

https://codereview.chromium.org/443853002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/443853002/diff/20001/include/v8.h#newcode5167
include/v8.h:5167: void ResetInternal();
nit: Can we move this up a few lines to before constructors are overridden? I'll
do this while landing if you don't mind.

[yhirano, 2014-08-07 08:50:54]

Thank you!

https://codereview.chromium.org/443853002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/443853002/diff/20001/include/v8.h#newcode5167
include/v8.h:5167: void ResetInternal();
On 2014/08/07 08:40:36, Michael Starzinger wrote:
> nit: Can we move this up a few lines to before constructors are overridden?
I'll
> do this while landing if you don't mind.

For readability? Then it is OK to do so.

[Michael Starzinger, 2014-08-07 08:53:53]

https://codereview.chromium.org/443853002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/443853002/diff/20001/include/v8.h#newcode5167
include/v8.h:5167: void ResetInternal();
On 2014/08/07 08:50:54, yhirano wrote:
> On 2014/08/07 08:40:36, Michael Starzinger wrote:
> > nit: Can we move this up a few lines to before constructors are overridden?
> I'll
> > do this while landing if you don't mind.
> 
> For readability? Then it is OK to do so.

Yes, for readability and consistency with the rest of the file.

[Michael Starzinger, 2014-08-07 08:56:13]

Committed patchset #2 manually as 22963 (presubmit successful).