v8::TryCatch should cancel the scheduled exception on Reset.

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index f702166cd4d281965f2caba33a616888eb7cb0fb..5514b67374220ae140f5c70fc202203a4bfa943c 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -5114,7 +5114,8 @@ class V8_EXPORT TryCatch {
 
   /**
    * Clears any exceptions that may have been caught by this try/catch block.
-   * After this method has been called, HasCaught() will return false.
+   * After this method has been called, HasCaught() will return false. Cancels
+   * the scheduled exception if it is caught and ReThrow() is not called before.
    *
    * It is not necessary to clear a try/catch block before using it again; if
    * another exception is thrown the previously caught exception will just be
@@ -5163,6 +5164,8 @@ class V8_EXPORT TryCatch {
   void* operator new(size_t size);
   void operator delete(void*, size_t);
 
+  void ResetInternal();

[Michael Starzinger, 2014/08/07 08:40:36]

nit: Can we move this up a few lines to before constructors are overridden? I'll
do this while landing if you don't mind.

[yhirano, 2014/08/07 08:50:54]

For readability? Then it is OK to do so.

[Michael Starzinger, 2014/08/07 08:53:53]

Yes, for readability and consistency with the rest of the file.

+
   v8::internal::Isolate* isolate_;
   v8::TryCatch* next_;
   void* exception_;