Issue 443623002: Revert of Resubmit: Remove deprecated extension notifications from ProcessManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 443623002: Revert of Resubmit: Remove deprecated extension notifications from ProcessManager (Closed)

Created:
6 years, 4 months ago by Adrian Kuegel

Modified:
6 years, 4 months ago

Reviewers:
Devlin, limasdf

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Resubmit: Remove deprecated extension notifications from ProcessManager (https://codereview.chromium.org/434593002/) Reason for revert: Speculative revert, see http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5773/steps/unit_tests/logs/GetHostZoomMap The stack trace mentions extensions::ExtensionRegistry::RemoveObserver Original issue's description: > Remove deprecated extension notifications from ProcessManager and use ExtensionRegistry instead. > > ProcessManagerTest inherts ExtensionsTest for the test settings. So now unit test is passed. > > R=rdevlin.cronin@chromium.org > BUG=354046 > TEST=extensions_unittests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287521 TBR=rdevlin.cronin@chromium.org,limasdf@gmail.com NOTREECHECKS=true NOTRY=true BUG=354046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287530

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -42 lines)			Patch
M	extensions/browser/process_manager.h	View	4 chunks	+1 line, -15 lines	0 comments	Download
M	extensions/browser/process_manager.cc	View	4 chunks	+34 lines, -27 lines	0 comments	Download
M	extensions/browser/process_manager_unittest.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Adrian Kuegel

Created Revert of Resubmit: Remove deprecated extension notifications from ProcessManager

6 years, 4 months ago (2014-08-05 13:27:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/443623002/1

6 years, 4 months ago (2014-08-05 13:28:36 UTC) #2

Message was sent while issue was closed.

Change committed as 287530