Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 434593002: Resubmit: Remove deprecated extension notifications from ProcessManager (Closed)

Created:
6 years, 4 months ago by limasdf
Modified:
6 years, 4 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated extension notifications from ProcessManager and use ExtensionRegistry instead. ProcessManagerTest inherts ExtensionsTest for the test settings. So now unit test is passed. R=rdevlin.cronin@chromium.org BUG=354046 TEST=extensions_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287521

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -47 lines) Patch
M extensions/browser/process_manager.h View 4 chunks +15 lines, -1 line 0 comments Download
M extensions/browser/process_manager.cc View 1 4 chunks +27 lines, -34 lines 0 comments Download
M extensions/browser/process_manager_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
limasdf
PTAL. I hope no reverting!
6 years, 4 months ago (2014-07-31 15:34:11 UTC) #1
Devlin
lgtm with nit. :) https://codereview.chromium.org/434593002/diff/40001/extensions/browser/process_manager.cc File extensions/browser/process_manager.cc (right): https://codereview.chromium.org/434593002/diff/40001/extensions/browser/process_manager.cc#newcode731 extensions/browser/process_manager.cc:731: if (system->ready().is_signaled()) { Let's go ...
6 years, 4 months ago (2014-08-04 18:45:20 UTC) #2
limasdf
https://codereview.chromium.org/434593002/diff/40001/extensions/browser/process_manager.cc File extensions/browser/process_manager.cc (right): https://codereview.chromium.org/434593002/diff/40001/extensions/browser/process_manager.cc#newcode731 extensions/browser/process_manager.cc:731: if (system->ready().is_signaled()) { On 2014/08/04 18:45:20, Devlin wrote: > ...
6 years, 4 months ago (2014-08-05 06:26:52 UTC) #3
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 4 months ago (2014-08-05 06:26:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/434593002/60001
6 years, 4 months ago (2014-08-05 06:28:54 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 10:54:08 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 11:18:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/2779)
6 years, 4 months ago (2014-08-05 11:18:59 UTC) #8
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 4 months ago (2014-08-05 11:34:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/434593002/60001
6 years, 4 months ago (2014-08-05 11:38:40 UTC) #10
commit-bot: I haz the power
Change committed as 287521
6 years, 4 months ago (2014-08-05 12:23:19 UTC) #11
Adrian Kuegel
A revert of this CL has been created in https://codereview.chromium.org/443623002/ by akuegel@chromium.org. The reason for ...
6 years, 4 months ago (2014-08-05 13:27:26 UTC) #12
limasdf
6 years, 4 months ago (2014-08-06 18:00:08 UTC) #13
Message was sent while issue was closed.
Maybe I should debug with ASAN?

Powered by Google App Engine
This is Rietveld 408576698